Re: Code review request for Linux version id fix (6986195)

2013-09-20 Thread Gerald Thornbrugh
Hi Omair, Thanks for the review! Jerry On 09/16/2013 01:31 PM, Gerald Thornbrugh wrote: OK, one more time: 2181 // Searching system-release (Red Hat) and os-release (other Linuxes) are a 2182 // next to last resort. The os-release file is a new standard that contains 2183 // distribution inf

Re: Code review request for Linux version id fix (6986195)

2013-09-20 Thread Gerald Thornbrugh
Hi Omair, I am the originator for the fix, Dan posted my review for me. Sorry about the delay of my response. In the openSuSE case the /etc/SuSE-release file seemed to have a more clear and concise distribution information than the /etc/os-release file. The /etc/SuSE-release file contains three

Re: Code review request for Linux version id fix (6986195)

2013-09-20 Thread Gerald Thornbrugh
Hi Omair, Hi Gerald, On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote: Sorry about the delay of my response. No problem :) I chose to place the /etc/SuSE-release file in front of the /etc/os-release file because the SuSE-release file was more clear and concise than the os-release file. I see

Re: Code review request for Linux version id fix (6986195)

2013-09-20 Thread Gerald Thornbrugh
Hi Dan, On 9/16/13 11:10 AM, Gerald Thornbrugh wrote: Hi Omair, Hi Gerald, On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote: Sorry about the delay of my response. No problem :) I chose to place the /etc/SuSE-release file in front of the /etc/os-release file because the SuSE-release file was

Re: Code review request for Linux version id fix (6986195)

2013-09-16 Thread Omair Majid
On 09/16/2013 01:31 PM, Gerald Thornbrugh wrote: > OK, one more time: > > 2181 // Searching system-release (Red Hat) and os-release (other > Linuxes) are a > 2182 // next to last resort. The os-release file is a new standard that > contains > 2183 // distribution information and the system-releas

Re: Code review request for Linux version id fix (6986195)

2013-09-16 Thread Daniel D. Daugherty
On 9/16/13 11:10 AM, Gerald Thornbrugh wrote: Hi Omair, Hi Gerald, On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote: Sorry about the delay of my response. No problem :) I chose to place the /etc/SuSE-release file in front of the /etc/os-release file because the SuSE-release file was more cle

Re: Code review request for Linux version id fix (6986195)

2013-09-16 Thread Omair Majid
Hi Gerald, On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote: > Sorry about the delay of my response. No problem :) > I chose to place the /etc/SuSE-release file in front of the > /etc/os-release file because the > SuSE-release file was more clear and concise than the os-release file. I see. Yes,

Code review request for Linux version id fix (6986195)

2013-09-12 Thread Daniel D. Daugherty
Greetings, I am sponsoring the following code review for Jerry Thornbrugh. Since this code review request is going to two aliases, please make sure you include BOTH aliases in your replies. Dan OpenJDK bug: 6986195 correctly identify Ubuntu as the operating system in crash rep

Re: Code review request for Linux version id fix (6986195)

2013-09-12 Thread Daniel D. Daugherty
> http://cr.openjdk.java.net/~dcubed/for_gthornbr/6986195-webrev/ src/os/linux/vm/os_linux.cpp No comments. Thumbs up. Just for the record, the internal review team was: dcubed dsamersoff coleenp iklam Dan On 9/12/13 2:00 PM, Daniel D. Daugherty wrote: Greetings, I am

Re: Code review request for Linux version id fix (6986195)

2013-09-12 Thread Omair Majid
Hi, On 09/12/2013 04:00 PM, Daniel D. Daugherty wrote: > The "lsb-release" file is the new Linux standard so it is now in the list. > I also added the "system-release" and "os-release" files since they are > an old standard. Actually, /etc/os-release is a fairly new thing [1] that is required by