You didn't print the NPE stacktrace in OpenMBeanInfoHashCodeNPETest.java
Otherwise ok.
No need to rereview if you add the stacktrace printing.
Thanks,
David
On 11/09/2013 10:32 PM, shanliang wrote:
David Holmes wrote:
Ok functional change seems fine.
Looking at the tests a few minor nits:
David Holmes wrote:
Ok functional change seems fine.
Looking at the tests a few minor nits:
test/javax/management/openmbean/OpenMBeanInfoEqualsNPETest.java
163 obj1.equals(null);
...
184 obj1.equals(null);
I think line 163 can be deleted.
Yes.
In both tests ...
On 11/09/2013 5:33 PM, shanliang wrote:
David Holmes wrote:
I'm a bit confused. The two webrevs are vastly different:
http://cr.openjdk.java.net/~sjiang/jdk-8023529/01/
http://cr.openjdk.java.net/~sjiang/jdk-8023529/00/
Should they be combined somehow?
The version 01 is correct.
The version
David Holmes wrote:
I'm a bit confused. The two webrevs are vastly different:
http://cr.openjdk.java.net/~sjiang/jdk-8023529/01/
http://cr.openjdk.java.net/~sjiang/jdk-8023529/00/
Should they be combined somehow?
The version 01 is correct.
The version 00 was a mistake, yesterday I had some pr
I'm a bit confused. The two webrevs are vastly different:
http://cr.openjdk.java.net/~sjiang/jdk-8023529/01/
http://cr.openjdk.java.net/~sjiang/jdk-8023529/00/
Should they be combined somehow?
David
-
On 11/09/2013 12:15 AM, shanliang wrote:
Jaroslav Bachorik wrote:
On 09/05/2013 10:37
Jaroslav Bachorik wrote:
On 09/05/2013 10:37 AM, shanliang wrote:
I have added 2 tasts to make sure that call
OpenMBean*InfoSupport.equals/hashCode do not throw NPE
The unit tests and JCK tests are passed.
Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8023529/00/
Bug: https://bugs.openjdk.j
I have added 2 tasts to make sure that call
OpenMBean*InfoSupport.equals/hashCode do not throw NPE
The unit tests and JCK tests are passed.
Webrev: http://cr.openjdk.java.net/~sjiang/JDK-8023529/00/
Bug: https://bugs.openjdk.java.net/browse/JDK-8023529
Thanks,
Shanliang
