Re: jmx-dev Codereview request: 8026028 [findbugs] findbugs report some issue in com.sun.jmx.snmp package

2013-10-18 Thread shanliang
Thanks Paul and Daniel for the review. Shanliang Daniel Fuchs wrote: Hi Shanliang, Looks good! -- daniel On 10/16/13 3:58 PM, shanliang wrote: Hi, Please review the following fix, main issue here is that we should clone an internal variable before returning. webrev: http://cr.openjdk.jav

Re: Codereview request: 8026028 [findbugs] findbugs report some issue in com.sun.jmx.snmp package

2013-10-17 Thread Paul Sandoz
On Oct 16, 2013, at 3:58 PM, shanliang wrote: > Hi, > > Please review the following fix, main issue here is that we should clone an > internal variable before returning. > > webrev: > http://cr.openjdk.java.net/~sjiang/JDK-8026028/00/ > > bug > https://bugs.openjdk.java.net/browse/JDK-802602

Re: jmx-dev Codereview request: 8026028 [findbugs] findbugs report some issue in com.sun.jmx.snmp package

2013-10-17 Thread Daniel Fuchs
Hi Shanliang, Looks good! -- daniel On 10/16/13 3:58 PM, shanliang wrote: Hi, Please review the following fix, main issue here is that we should clone an internal variable before returning. webrev: http://cr.openjdk.java.net/~sjiang/JDK-8026028/00/ bug https://bugs.openjdk.java.net/browse/J

Codereview request: 8026028 [findbugs] findbugs report some issue in com.sun.jmx.snmp package

2013-10-16 Thread shanliang
Hi, Please review the following fix, main issue here is that we should clone an internal variable before returning. webrev: http://cr.openjdk.java.net/~sjiang/JDK-8026028/00/ bug https://bugs.openjdk.java.net/browse/JDK-8026028 Thanks, Shanliang