FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits

2020-08-04 Thread 傅杰
Forward it to serviceability-dev since this issue in the JBS has been moved from hotspot/runtime to core-svc/java.lang.management. Please review it. Thanks. Best regards, Jie From: "jiefu(傅杰)" Date: Tuesday, August 4, 2020 at 5:10 PM To: "hotspot-runtime-...@openjdk.java.net" Subject: RFR:

Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits

2020-08-04 Thread Chris Plummer
Hi Jie, The fix appears to directly address the issue of allowing a hostname to start with a digit. I'm still not convinced that the check will properly validate the hostname in all cases, but maybe that's a fix for another day: https://stackoverflow.com/questions/1418423/the-hostname-regex

Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits

2020-08-04 Thread David Holmes
My Review still stands. :) Thanks, David On 5/08/2020 1:10 am, jiefu(傅杰) wrote: Forward it to serviceability-dev since this issue in the JBS has been moved  from hotspot/runtime to core-svc/java.lang.management. Please review it. Thanks. Best regards, Jie *From: *"jiefu(傅杰)" *Date: *Tues

Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits(Internet mail)

2020-08-04 Thread 傅杰
Thanks Chris and David for your review. Will push it later. Best regards, Jie From: David Holmes Sent: Wednesday, August 5, 2020 9:03 AM To: jiefu(傅杰); serviceability-dev@openjdk.java.net Subject: Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean

Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits(Internet mail)

2020-08-04 Thread serguei.spit...@oracle.com
); serviceability-dev@openjdk.java.net Subject: Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits(Internet mail)   My Review still stands

Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits(Internet mail)

2020-08-04 Thread 傅杰
iceability-dev@openjdk.java.net> Subject: Re: FW: 8251031: Some vmTestbase/nsk/monitoring/RuntimeMXBean tests fail with hostnames starting from digits(Internet mail) My Review still stands. :) Thanks, David On 5/08/2020 1:10 am, jiefu(傅杰) wrote: > Forward it to serviceability-dev since this issue