Re: RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

On Tue, Oct 8, 2019 at 12:52 AM Daniil Titov wrote: > I will sponsor this change. > On Tue, Oct 8, 2019 at 1:01 AM serguei.spit...@oracle.com < serguei.spit...@oracle.com> wrote: > Looks good. > On Wed, Oct 9, 2019 at 12:20 AM Daniil Titov wrote: > I pushed the changes. > > The changeset:

Re: RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

Hi Evgeny, Looks good. Thanks, Serguei On 9/24/19 01:30, Evgeny Mandrikov wrote: On Tue, Sep 24, 2019 at 8:15 AM David Holmes

Re: RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

Hi Evgeny, I will sponsor this change. Thank you, Daniil From: serviceability-dev on behalf of Daniil Titov Date: Tuesday, September 24, 2019 at 9:49 PM To: Evgeny Mandrikov , David Holmes Cc: Subject: Re: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common

Re: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

Hi Evgeny, The change looks good to me. Thanks! --Daniil From: serviceability-dev on behalf of Evgeny Mandrikov Date: Tuesday, September 24, 2019 at 1:32 AM To: David Holmes Cc: Subject: Re: RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common

Re: RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

On Tue, Sep 24, 2019 at 8:15 AM David Holmes wrote: > I just spotted this review request languishing in the mailing list. > > The patch will need to be rebased against latest jdk sources, so please > do that. I'll see if I can drum up a second reviewer and get a sponsor. > Hi David, No pb,

Re: RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

Hi Evgeny, I just spotted this review request languishing in the mailing list. On 26/08/2019 4:36 am, Evgeny Mandrikov wrote: Hello! Please review patch [1] for JDK-8199136 [2]. Also it needs a sponsor since I have only author status in OpenJDK Census [3]. I looked at the discussion in the

RFR: JDK-8199136: Dead code in src/jdk.jcmd/share/classes/sun/tools/common/ProcessArgumentMatcher.java

Hello! Please review patch [1] for JDK-8199136 [2]. Also it needs a sponsor since I have only author status in OpenJDK Census [3]. After this change tier1 tests pass on my machine. With best regards, Evgeny Mandrikov [1] http://cr.openjdk.java.net/~godin/8199136/webrev.00/ [2]