Please see:
JDK-8216059 nsk_jvmti_parseoptions still has dependency on tilde separator
https://bugs.openjdk.java.net/browse/JDK-8216059
Dan
On 1/7/19 1:32 PM, JC Beyler wrote:
Hi Gary,
My only comment here is that it seems to that the delimiter list you
have there is not complete (or backwa
Hi Gary,
Looks good to me.
Thanks,
Serguei
On 12/31/18 10:06, gary.ad...@oracle.com wrote:
Here's a revised webrev.
Webrev:
http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8211343/webrev.01/
Updates in this round of changes :
- replaced index() with strchr() to avoi
Ok.
Chris
On 12/31/18 12:30 PM, gary.ad...@oracle.com wrote:
The one test that failed is changed in this webrev.
When it failed, it was the check in add_option
that does not allow an "empty" option name.
On 12/31/18 2:25 PM, Chris Plummer wrote:
Looks good. Are empty options strings still a
The one test that failed is changed in this webrev.
When it failed, it was the check in add_option
that does not allow an "empty" option name.
On 12/31/18 2:25 PM, Chris Plummer wrote:
Looks good. Are empty options strings still allowed after your changes?
Chris
On 12/31/18 10:06 AM, gary.ad
Looks good. Are empty options strings still allowed after your changes?
Chris
On 12/31/18 10:06 AM, gary.ad...@oracle.com wrote:
Here's a revised webrev.
Webrev:
http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8211343/webrev.01/
Updates in this round of changes :
- re
Here's a revised webrev.
Webrev:
http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8211343/webrev.01/
Updates in this round of changes :
- replaced index() with strchr() to avoid platform dependent issues
with strings.h include
- removed NSK_JVMTI_OPTION_VAL_SEP
- re
On 12/21/18 12:55 PM, gary.ad...@oracle.com wrote:
On 12/21/18 3:33 PM, serguei.spit...@oracle.com wrote:
Hi Gary,
Looks good in general.
Thank you for taking care about this!
A couple of comments.
It seems, with your fixes the macro NSK_JVMTI_OPTION_VAL_SEP is not
needed anymore.
Also, I
On 12/21/18 3:33 PM, serguei.spit...@oracle.com wrote:
Hi Gary,
Looks good in general.
Thank you for taking care about this!
A couple of comments.
It seems, with your fixes the macro NSK_JVMTI_OPTION_VAL_SEP is not
needed anymore.
Also, I wonder if it makes sense to continue using:
238 value
On 12/21/18 2:31 PM, Chris Plummer wrote:
Hi Gary,
This is much better. Just one question and a couple of minor comments:
The original code had the following:
225 context.options.string = (char*)malloc(len + 2);
...
231 strncpy(context.options.string, options, len);
232 context.
Hi Gary,
Looks good in general.
Thank you for taking care about this!
A couple of comments.
It seems, with your fixes the macro NSK_JVMTI_OPTION_VAL_SEP is
not needed anymore.
Also, I wonder if it makes sense to continue using:
Hi Gary,
This is much better. Just one question and a couple of minor comments:
The original code had the following:
225 context.options.string = (char*)malloc(len + 2);
...
231 strncpy(context.options.string, options, len);
232 context.options.string[len] = '\0';
233 contex
Here is a first pass at a replacement parser for jvmti test options.
Webrev: http://cr.openjdk.java.net/~gadams/8211343/webrev.00/
Issue: https://bugs.openjdk.java.net/browse/JDK-8211343
Testing is in progress. Need to check out more platforms.
On local linux testing one jvmti test failed Se
My intention is to establish a more robust argument parsing
and then see how much code and comments can be replaced.
Since strsep is BSD based and not available on windows,
an alternative is to use strpbrk which is on windows and
posix.
#include
#include
char* token(char **s, char *delim) {
Wow, the existing comments for this
function take a lot of work to translate. You basically need to
understand the code in order to understand the comment. Kind of
backwards. Below I've included all the existing code and comments,
with my translation of the commen
I prototyped with strsep, because strtok is not safe
and did not want to deal with the strtok_r versus
strtok_s (windows) platform variants.
...
#include
#include
int main(int argc, char **argv){
char *str = strdup("waittime=5,verbose foo bar baz=11");
char *name;
char *value;
while
Hi Gary,
I had seen that too and forgot to file it! So thanks!
I think the comment you removed is interesting, I'm not sure what it means
exactly and I've tried re-reading a few times but the use of "in this
question" is weird :-)
Anyway, the webrev looks good except perhaps for the use of strs
During some earlier jvmti test debugging, I noticed that it was not
possible to
add a quick argument to the current tests and rerun the test. e.g.
expand "waittime=5" to
"waittime=5,verbose". I tracked down the options parsing in
jvmti_tools.cpp and saw some
comments that only a single option c
17 matches
Mail list logo
