JDK 14 RFR of JDK-8232442: Suppress warnings on non-serializable non-transient instance fields in java.management.*

2019-10-16 Thread Joe Darcy
Hello, Quick background, ahead of strengthening javac's -Xlint:serial checks to include more aspects of a Serializable or Externalizable type ( JDK-8160675 ), I've been working through the JDK libraries to review issue found by the upcoming analysis (JDK-8231641). The latest segment of the l

Re: JDK 14 RFR of JDK-8232442: Suppress warnings on non-serializable non-transient instance fields in java.management.*

2019-10-17 Thread Roger Riggs
Hi Joe, These look ok. A few of them might be handled by making them transient, but SuppressWarnings calls more attention to them as fields that are being serialized, even indirectly. The presence of a writeReplace method weakens the coupling of the fields to the serialized values. Roger

Re: JDK 14 RFR of JDK-8232442: Suppress warnings on non-serializable non-transient instance fields in java.management.*

2019-10-17 Thread Joe Darcy
Hi Roger, I would certainly be in favor of a more thorough review of the use of serialization in the management modules by the serviceability team as follow-up work. Cheers, -Joe On 10/17/2019 11:29 AM, Roger Riggs wrote: Hi Joe, These look ok. A few of them might be handled by making th

Re: JDK 14 RFR of JDK-8232442: Suppress warnings on non-serializable non-transient instance fields in java.management.*

2019-10-23 Thread Joe Darcy
Serguei or others working directly in java.management, any other comments on these changes? Thanks, -Joe On 10/17/2019 3:58 PM, Joe Darcy wrote: Hi Roger, I would certainly be in favor of a more thorough review of the use of serialization in the management modules by the serviceability team

Re: JDK 14 RFR of JDK-8232442: Suppress warnings on non-serializable non-transient instance fields in java.management.*

2019-10-23 Thread Mandy Chung
This patch looks fine. Mandy On 10/23/19 10:27 AM, Joe Darcy wrote: Serguei or others working directly in java.management, any other comments on these changes? Thanks, -Joe On 10/17/2019 3:58 PM, Joe Darcy wrote: Hi Roger, I would certainly be in favor of a more thorough review of the use

Re: JDK 14 RFR of JDK-8232442: Suppress warnings on non-serializable non-transient instance fields in java.management.*

2019-10-23 Thread serguei.spit...@oracle.com
Hi Joe, Looks good to me. Thanks, Serguei On 10/23/19 10:27, Joe Darcy wrote: Serguei or others working directly in java.management, any other comments on these changes? Thanks, -Joe On 10/17/2019 3:58 PM, Joe Darcy wrote: Hi Roger, I would certainly be in favor of a more thorough revie