Re: Need Second Reviewer Re: RR(S): JDK-7127191 SA JSDB does not display native symbols correctly for transported Linux cores

Dmitry, It looks good. Thank you for answers and code adjustment. Thanks, Serguei On 1/31/14 1:48 AM, Dmitry Samersoff wrote: Serguei, Thank you for review. I'd updated webrev (see also below) http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.03/ On 2014-01-31 04:01, serguei.spit.

Re: Need Second Reviewer Re: RR(S): JDK-7127191 SA JSDB does not display native symbols correctly for transported Linux cores

Serguei, Thank you for review. I'd updated webrev (see also below) http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.03/ On 2014-01-31 04:01, serguei.spit...@oracle.com wrote: > Hi Dmitry, > > > agent/src/os/linux/libproc_impl.c > > Q: To the lines 56-71 (I'm taking a blame for askin

Re: Need Second Reviewer Re: RR(S): JDK-7127191 SA JSDB does not display native symbols correctly for transported Linux cores

Hi Dmitry, agent/src/os/linux/libproc_impl.c Q: To the lines 56-71 (I'm taking a blame for asking stupid questions): Is it possible the name argument has no leading slash '/' ? Does it work correctly in such a case? Is there a need to add a slash after the alt_path? agent/src/s

Need Second Reviewer Re: RR(S): JDK-7127191 SA JSDB does not display native symbols correctly for transported Linux cores

Hi Everyone, Please review the fix. http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.02/ -Dmitry On 2014-01-20 20:00, Dmitry Samersoff wrote: > Hi Everyone, > > Please review the fix. > > http://cr.openjdk.java.net/~dsamersoff/JDK-7127191/webrev.01/ > > This fix doesn't solve all pr