Re: Need reviewers, jdk7 testing changes

2009-12-09 Thread Joe Darcy
Kelly O'Hair wrote: Martin Buchholz wrote: On Tue, Dec 8, 2009 at 16:42, Kelly O'Hair wrote: In theory, the process is supposed to prevent regression test failures from ever creeping in - that's the whole point. When they do (inevitably) creep in, they are supposed to be aggressively targe

Re: Need reviewers, jdk7 testing changes

2009-12-09 Thread Kelly O'Hair
Martin Buchholz wrote: On Tue, Dec 8, 2009 at 16:42, Kelly O'Hair wrote: In theory, the process is supposed to prevent regression test failures from ever creeping in - that's the whole point. When they do (inevitably) creep in, they are supposed to be aggressively targeted. A gatekeeper demon

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Martin Buchholz
On Tue, Dec 8, 2009 at 16:42, Kelly O'Hair wrote: >> In theory, the process is supposed to prevent >> regression test failures from ever creeping in - that's the whole point. >> When they do (inevitably) creep in, >> they are supposed to be aggressively targeted. >> A gatekeeper demonstrates the

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Kelly O'Hair
Martin Buchholz wrote: On Mon, Dec 7, 2009 at 23:30, Martin Buchholz wrote: You cannot exclude the Mother Of All Tests. This is non-negotiable. More seriously... It's very difficult to manage creeping failures in regression tests. Tell me about it. :^( In theory, the process is suppos

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Martin Buchholz
On Mon, Dec 7, 2009 at 23:30, Martin Buchholz wrote: > You cannot exclude the Mother Of All Tests. > This is non-negotiable. More seriously... It's very difficult to manage creeping failures in regression tests. In theory, the process is supposed to prevent regression test failures from ever cr

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Joseph D. Darcy
Kelly O'Hair wrote: Need reviewer for JDK7 testing changes, e.g. testing via: cd jdk/make && gmake all images && cd ../test && gmake jdk_all 6906210: Fix another minor typo in test/Makefile http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ Dan had pointed out my typo i

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Kelly O'Hair
Martin Buchholz wrote: On Mon, Dec 7, 2009 at 13:43, Tim Bell wrote: java/util/Collection/MOAT.java It is a shame we have to exclude Martin's MOAT.java (Mother Of All Tests) The comment shows the test failing on Solaris 10 x86, but you exclude it on generic-all You cannot exclude the Mot

Re: Need reviewers, jdk7 testing changes

2009-12-08 Thread Alan Bateman
Kelly O'Hair wrote: : Dan had pointed out my typo in the jdk/test/Makefile ($->$$) but when I started running and re-running the tests I ran into more unstable tests. This webrev includes fixes to 3 tests and unfortuntately more additions to the ProblemList file. It would be good to create a bu

Re: Need reviewers, jdk7 testing changes

2009-12-07 Thread Martin Buchholz
On Mon, Dec 7, 2009 at 13:43, Tim Bell wrote: >>    java/util/Collection/MOAT.java > > It is a shame we have to exclude Martin's MOAT.java (Mother Of All Tests) > The comment shows the test failing on Solaris 10 x86, but you exclude > it on generic-all You cannot exclude the Mother Of All Tests.

Re: Need reviewers, jdk7 testing changes

2009-12-07 Thread Tim Bell
Hi Kelly See below: > Need reviewer for JDK7 testing changes, e.g. testing via: >cd jdk/make && gmake all images && cd ../test && gmake jdk_all > > 6906210: Fix another minor typo in test/Makefile > http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ > > Dan had pointe

Need reviewers, jdk7 testing changes

2009-12-07 Thread Kelly O'Hair
Need reviewer for JDK7 testing changes, e.g. testing via: cd jdk/make && gmake all images && cd ../test && gmake jdk_all 6906210: Fix another minor typo in test/Makefile http://cr.openjdk.java.net/~ohair/openjdk7/jdk7-tl-test-changes4/webrev/ Dan had pointed out my typo in the jdk/test/Makefi