Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-12 Thread Chihiro Ito
Hi, I agree with Yasunaga's idea. The current implementation seems to be required for the JVM to read and write. According to the test results, it is difficult to improve this. However, as in JBS, we also need human-readable output. Regards, Chihiro 2020年3月12日(木) 12:15 Chihiro Ito : > > Hi Sergu

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-11 Thread Chihiro Ito
Hi Serguei, I could not fail these tests on my environment. I would like to see more detail bug information especially the environment variable. Could you share with me the test-result, please? Regards, Chihiro 2020年3月12日(木) 10:32 Yasumasa Suenaga : > > Hi, > > AFAICS failure tests which are lis

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-11 Thread Yasumasa Suenaga
Hi, AFAICS failure tests which are listed in JBS (JDK-8240881) seems to be caused by HotSpotVirtualMachine::getSystemProperties. It would load the result of PrintSystemPropertiesDCmd via Properties::load. So we have to compliant the spec of Properties. OTOH it is not described in spec (JDK-712

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-11 Thread Daniel D. Daugherty
The replacement bug should be filed with this description:     [REDO] 8222489 jcmd VM.system_properties gives unusable paths on Windows and should be linked to the original bug also. Dan On 3/11/20 3:52 PM, serguei.spit...@oracle.com wrote: Hi Chihiro, I've tested and pushed your fix but

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-11 Thread serguei.spit...@oracle.com
Hi Chihiro, I've tested and pushed your fix but the impact of fix was underestimated. The fix caused several regressions and the following bug was filed:   https://bugs.openjdk.java.net/browse/JDK-8240881 Now, I'm working on removing the fix of JDK-8222489 with the anti-delta. You can find and r

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-10 Thread serguei.spit...@oracle.com
Hi Chihiro, Yes, I'll sponsor it. Thank you for the update. Thanks, Serguei On 3/8/20 06:05, Chihiro Ito wrote: Hi, I'm sorry. I included "JDK-" in the changeset title. I removed it and updated it. Change set : http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.06/changeset Regards, Chihi

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-08 Thread Chihiro Ito
Hi, I'm sorry. I included "JDK-" in the changeset title. I removed it and updated it. Change set : http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.06/changeset Regards, Chihiro 2020年3月7日(土) 23:13 Chihiro Ito : > > Hi Serguei and Yasumasa, > > I update the copyright year and created the chan

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-07 Thread Chihiro Ito
Hi Serguei and Yasumasa, I update the copyright year and created the change set. Could you sponsor this, please? Webrev : http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.06/ Change set : http://cr.openjdk.java.net/~cito/JDK-8222489/webrev.06/changeset Regards, Chihiro 2020年3月7日(土) 16:03 Y

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-06 Thread Yasumasa Suenaga
Hi Chihiro, I'm also ok with webrev.05 after updating copyright year. Yasumasa On 2020/03/07 3:32, serguei.spit...@oracle.com wrote: Hi Chichiro, I'm okay with the fix. Could you, please, update the copyright date in || src/java.base/share/classes/jdk/internal/vm/VMSupport.java before push

Re: PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-06 Thread serguei.spit...@oracle.com
Hi Chichiro, I'm okay with the fix. Could you, please, update the copyright date in src/java.base/share/classes/jdk/internal/vm/VMSupport.java before push? Thanks, Serguei On 3/6/20 07:24, Chihiro Ito wrote:

PING: Re: RFR: JDK-8222489: jcmd VM.system_properties gives unusable paths on Windows

2020-03-06 Thread Chihiro Ito
Hi Serguei, Could you review this again, please? Regards, Chihiro 2020年2月27日(木) 22:11 Chihiro Ito : > > Hi Ralf, > > Thank you for your advice. > > 1. > The comment of serializePropertiesToByteArray in VMSupport is "The stream > written to the byte array is ISO 8859-1 encoded.". > But the prev