RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-18 Thread Markus Grönlund
gt; To: Markus Grönlund > Cc: Karen Kinnear; serviceability-dev@openjdk.java.net; > hotspot-gc-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net > Subject: Re: RFR(M): 8012182: Add information about class loading and > unloading to event based tracing framework (hs24) - updated > >

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-18 Thread David Holmes
id Holmes Sent: den 17 april 2013 03:46 To: Markus Grönlund Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net; hotspot-gc-...@openjdk.java.net Subject: Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) -

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-18 Thread Markus Grönlund
; hotspot-runtime-...@openjdk.java.net Subject: Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated Markus, It looks good. Thanks, Serguei On 4/17/13 10:46 PM, Markus Grönlund wrote: > Thanks David and Sergeui, > > I h

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-18 Thread serguei.spit...@oracle.com
rom: David Holmes Sent: den 17 april 2013 03:46 To: Markus Grönlund Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net; hotspot-gc-...@openjdk.java.net Subject: Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) -

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread Markus Grönlund
nlund > Sent: den 17 april 2013 09:48 > To: David Holmes > Cc: serviceability-dev@openjdk.java.net; > hotspot-gc-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net > Subject: RE: RFR(M): 8012182: Add information about class loading and > unloading to event based tracing

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread David Holmes
David Holmes; Karen Kinnear Cc: serviceability-dev@openjdk.java.net; hotspot-gc-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated Hi again, Updated webre

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread serguei.spit...@oracle.com
a.net; hotspot-gc-...@openjdk.java.net; hotspot-runtime-...@openjdk.java.net Subject: RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated Hi again, Updated webrev (v3) trying to respect the loader constraint checking before event po

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread Markus Grönlund
et Subject: RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated First, I forgot to mention in the original post that parts of this code was contributed-by: Calvin Cheung (calvin.che...@oracle.com) Calvin will be attribut

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread Markus Grönlund
03:46 To: Markus Grönlund Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev@openjdk.java.net; hotspot-gc-...@openjdk.java.net Subject: Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated Hi Markus, On 17/04/2013 7:35 A

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-17 Thread Markus Grönlund
bility-dev@openjdk.java.net; hotspot-gc-...@openjdk.java.net Subject: Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated Hi Markus, On 17/04/2013 7:35 AM, Markus Grönlund wrote: > Hi again, > > The changeset for thi

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-16 Thread David Holmes
Hi Markus, On 17/04/2013 7:35 AM, Markus Grönlund wrote: Hi again, The changeset for this has been updated slightly to reflect underlying changes in hs24. Still looking for reviews for this change to add information about class loading and unloading to the event based tracing framework for HS2

RE: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-16 Thread Markus Grönlund
viceability-dev@openjdk.java.net"serviceability-dev@openjdk.java.net; HYPERLINK "mailto:hotspot-gc-...@openjdk.java.net"hotspot-gc-...@openjdk.java.net Subject: Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated   Markus,  

Re: RFR(M): 8012182: Add information about class loading and unloading to event based tracing framework (hs24) - updated

2013-04-16 Thread Karen Kinnear
Markus, Looks good. Minor comments: 1. systemDictionary.cpp Does the post_class_load_event internal logic want to be #ifdef INCLUDE_TRACE/#endif so it builds with embedded? 2. tracestream.hpp print_val (both) - don't you need a ResourceMark rm to use as_C_string() and name_and_sig_as_C_st