Re: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

2016-04-29 Thread David Holmes
On 30/04/2016 5:39 AM, Martin Buchholz wrote: Thanks, looks good. (In future, please notify code owners using the relevant mailing lists, in this case core-libs-dev) Harold was given incorrect information as to the owning area in this case. Cheers, David On Fri, Apr 29, 2016 at 12:32 PM, ha

Re: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

2016-04-29 Thread harold seigel
Thanks for the review. Harold On 4/29/2016 3:39 PM, Martin Buchholz wrote: Thanks, looks good. (In future, please notify code owners using the relevant mailing lists, in this case core-libs-dev) On Fri, Apr 29, 2016 at 12:32 PM, harold seigel wrote: Please review this updated webrev that us

Re: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

2016-04-29 Thread Martin Buchholz
Thanks, looks good. (In future, please notify code owners using the relevant mailing lists, in this case core-libs-dev) On Fri, Apr 29, 2016 at 12:32 PM, harold seigel wrote: > Please review this updated webrev that uses Martin's fix: > > New webrev: http://cr.openjdk.java.net/~hseigel/bug_81557

Re: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

2016-04-29 Thread harold seigel
Please review this updated webrev that uses Martin's fix: New webrev: http://cr.openjdk.java.net/~hseigel/bug_8155727.1/ Thanks, Harold On 4/29/2016 3:19 PM, Martin Buchholz wrote: Apologies for taking over here ... This test is maintained externally in JSR166 CVS. We prefer a version that w

Re: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

2016-04-29 Thread harold seigel
Hi Martin, Sure. I'll send out another RFR shortly. Harold On 4/29/2016 3:19 PM, Martin Buchholz wrote: Apologies for taking over here ... This test is maintained externally in JSR166 CVS. We prefer a version that works well with both old and new outputs. I suggest instead "(?m)^ *[0-9]+:

Re: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

2016-04-29 Thread Martin Buchholz
Apologies for taking over here ... This test is maintained externally in JSR166 CVS. We prefer a version that works well with both old and new outputs. I suggest instead "(?m)^ *[0-9]+: +([0-9]+) +[0-9]+ +\\Q"+className+"\\E(?:$| )"; Does that work with latest serviceability changes? On Fri, A

Re: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

2016-04-29 Thread harold seigel
Thanks Christian! Harold On 4/29/2016 2:14 PM, Christian Tornqvist wrote: Hi Harold, This looks good, thanks for fixing this! Thanks, Christian -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of harold seigel Sent: Friday,

RE: RFR(XS) 8155727: java/util/concurrent/locks/Lock/TimedAcquireLeak.java timeouts.

2016-04-29 Thread Christian Tornqvist
Hi Harold, This looks good, thanks for fixing this! Thanks, Christian -Original Message- From: serviceability-dev [mailto:serviceability-dev-boun...@openjdk.java.net] On Behalf Of harold seigel Sent: Friday, April 29, 2016 2:01 PM To: serviceability-dev@openjdk.java.net Subject: RFR(XS)