Hi Kevin,
> -Original Message-
> From: Kevin Walls
> Sent: Tuesday, July 02, 2019 2:18 PM
> To: Fairoz Matte ; serviceability-
> d...@openjdk.java.net
> Subject: Re: RFR: 8225715: jhsdb jmap fails to write binary heap dump of a
> jshell process
>
> Hi Fairoz
Hi Fairoz -
Looks good to me too.
The " -encoding utf8" in the test might be a leftover from something
else (maybe /timeout=240 also?), you could leave it out but no problem
either way.
Thanks!
Kevin
On 01/07/2019 05:31, Fairoz Matte wrote:
Hi,
Please review a fix that potentially handle
Hi Chris,
Thanks for the review.
Thanks,
Fairoz
> -Original Message-
> From: Chris Plummer
> Sent: Monday, July 01, 2019 11:21 PM
> To: Fairoz Matte ; serviceability-
> d...@openjdk.java.net
> Subject: Re: RFR: 8225715: jhsdb jmap fails to write binary heap dump of
Looks good.
Chris
On 6/30/19 9:31 PM, Fairoz Matte wrote:
Hi,
Please review a fix that potentially handle NPE and allow heap to dump from a
process were we get source file name as null.
Background:
For taking heap dump of JShell process, we get getSourceFileName() as null.
Current implementat
