Re: RFR: 8232370: Refactor some com.sun.jdi tests to enable IDE integration

2019-10-16 Thread Alex Menkov
Ho Christoph, Looks good to me. --alex On 10/16/2019 07:10, Langer, Christoph wrote: Hi, please review this little test refactoring to better support IDE integration. There are a few classes defined twice in the com/sun/jdi test folder and hence cause ambiguity problems if the whole folder

Re: RFR: 8232370: Refactor some com.sun.jdi tests to enable IDE integration

2019-10-16 Thread Chris Plummer
+1 On 10/16/19 11:54 AM, Alex Menkov wrote: Ho Christoph, Looks good to me. --alex On 10/16/2019 07:10, Langer, Christoph wrote: Hi, please review this little test refactoring to better support IDE integration. There are a few classes defined twice in the com/sun/jdi test folder and hence

Re: RFR: 8232370: Refactor some com.sun.jdi tests to enable IDE integration

2019-10-16 Thread serguei.spit...@oracle.com
Hi Christoph, It looks good. Thank you for catching and fixing it! Thanks, Serguei On 10/16/19 07:10, Langer, Christoph wrote: Hi,   please review this little test refact

RE: RFR: 8232370: Refactor some com.sun.jdi tests to enable IDE integration

2019-10-17 Thread Langer, Christoph
Thanks for the reviews. > -Original Message- > From: Chris Plummer > Sent: Mittwoch, 16. Oktober 2019 21:30 > To: Alex Menkov ; Langer, Christoph > ; OpenJDK Serviceability d...@openjdk.java.net> > Subject: Re: RFR: 8232370: Refactor some com.sun.jdi tests to ena