Re: RFR(M): 8030812 : Change the solaris DTrace implementation to use USDT2 instead of USDT1

2014-01-13 Thread Dmitry Samersoff
Staffan, Looks good for me. -Dmitry On 2014-01-13 14:30, Staffan Larsen wrote: > I’m still looking for a Review of this change (I know it’s nobody’s favorite > code…). > > Thanks, > /Staffan > > On 20 dec 2013, at 12:58, Staffan Larsen wrote: > >> The DTrace static probe implementation in H

Re: RFR(M): 8030812 : Change the solaris DTrace implementation to use USDT2 instead of USDT1

2014-01-13 Thread Staffan Larsen
I’m still looking for a Review of this change (I know it’s nobody’s favorite code…). Thanks, /Staffan On 20 dec 2013, at 12:58, Staffan Larsen wrote: > The DTrace static probe implementation in Hotspot was written with an earlier > version of DTrace. With newer versions, DTrace can create a h

Re: RFR(M): 8030812 : Change the solaris DTrace implementation to use USDT2 instead of USDT1

2014-01-07 Thread serguei.spit...@oracle.com
On 1/7/14 3:47 AM, Staffan Larsen wrote: On 20 dec 2013, at 22:07, serguei.spit...@oracle.com wrote: Staffan, This is nice change and cleanup. I do not see any issues. Thanks. The make/bsd/makefiles/dtrace.make shows that the jhelper.d is disabled for bsd which means that the jstack action

Re: RFR(M): 8030812 : Change the solaris DTrace implementation to use USDT2 instead of USDT1

2014-01-07 Thread Staffan Larsen
On 20 dec 2013, at 22:07, serguei.spit...@oracle.com wrote: > Staffan, > > This is nice change and cleanup. > I do not see any issues. Thanks. > The make/bsd/makefiles/dtrace.make shows that the jhelper.d is disabled for > bsd > which means that the jstack action is not supported there. > I'm

Re: RFR(M): 8030812 : Change the solaris DTrace implementation to use USDT2 instead of USDT1

2013-12-20 Thread serguei.spit...@oracle.com
Staffan, This is nice change and cleanup. I do not see any issues. The make/bsd/makefiles/dtrace.make shows that the jhelper.d is disabled for bsd which means that the jstack action is not supported there. I'm not very familiar with the BSD DTrace implementation and wonder if you know any det

RFR(M): 8030812 : Change the solaris DTrace implementation to use USDT2 instead of USDT1

2013-12-20 Thread Staffan Larsen
The DTrace static probe implementation in Hotspot was written with an earlier version of DTrace. With newer versions, DTrace can create a header file from the contents of the .d file that describes the probes. This newer version (called USDT2) has been used on OS X. Because we have had both vers