Re: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-05 Thread Dmitry Samersoff
. >> >> I'm still unclear why the attachListener.hpp changes are needed if we >> have validated the entry points in the attachListener_.cpp files? >> >> Also we still need someone from serviceability to comment on the _NSIG >> issue. >> >> Thanks,

RE: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-05 Thread Lindenmaier, Goetz
erstag, 5. November 2015 11:15 > To: Lindenmaier, Goetz > Cc: hotspot-runtime-...@openjdk.java.net; serviceability-dev; David > Holmes > Subject: RE: RFR(M): 8140482: Various minor code improvements (runtime) > > Hi Goetz, > > Thanks for suggesting these fixes. > > Also than

Re: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-05 Thread serguei.spit...@oracle.com
David Holmes; Lindenmaier, Goetz; hotspot-runtime-...@openjdk.java.net; serviceability-dev *Subject:* Re: RFR(M): 8140482: Various minor code improvements (runtime) Hi Goetz, The fix looks good. Thanks for the improvements! The _NSIG related fix looks Ok to me but I do not feel myself qualifi

RE: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-05 Thread Lindenmaier, Goetz
e.com [mailto:serguei.spit...@oracle.com] Sent: Donnerstag, 5. November 2015 04:49 To: David Holmes; Lindenmaier, Goetz; hotspot-runtime-...@openjdk.java.net; serviceability-dev Subject: Re: RFR(M): 8140482: Various minor code improvements (runtime) Hi Goetz, The fix looks good. Thanks for the impro

RE: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-05 Thread Markus Gronlund
>> From: David Holmes [mailto:david.hol...@oracle.com] >> Sent: Mittwoch, 4. November 2015 08:15 >> To: Lindenmaier, Goetz; hotspot-runtime-...@openjdk.java.net; >> serviceability-dev >> Subject: Re: RFR(M): 8140482: Various minor code improvements >> (runtime) >>

Re: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-04 Thread serguei.spit...@oracle.com
d Holmes [mailto:david.hol...@oracle.com] Sent: Mittwoch, 4. November 2015 08:15 To: Lindenmaier, Goetz; hotspot-runtime-...@openjdk.java.net; serviceability-dev Subject: Re: RFR(M): 8140482: Various minor code improvements (runtime) Hi Goetz, On 4/11/2015 12:10 AM, Lindenmaier, Goetz wrote: Hi David,

Re: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-04 Thread David Holmes
--Original Message- From: David Holmes [mailto:david.hol...@oracle.com] Sent: Dienstag, 3. November 2015 11:07 To: Lindenmaier, Goetz; hotspot-runtime-...@openjdk.java.net; serviceability-dev Subject: Re: RFR(M): 8140482: Various minor code improvements (runtime) Hi Goetz, Quick follow up on a

RE: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-04 Thread Lindenmaier, Goetz
untime-...@openjdk.java.net; > serviceability-dev > Subject: Re: RFR(M): 8140482: Various minor code improvements (runtime) > > Hi Goetz, > > On 4/11/2015 12:10 AM, Lindenmaier, Goetz wrote: > > Hi David, > > > > the new scan is already through. I made a new webr

Re: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-03 Thread David Holmes
, 3. November 2015 11:07 To: Lindenmaier, Goetz; hotspot-runtime-...@openjdk.java.net; serviceability-dev Subject: Re: RFR(M): 8140482: Various minor code improvements (runtime) Hi Goetz, Quick follow up on a couple of things ... On 3/11/2015 7:33 PM, Lindenmaier, Goetz wrote: Hi David, Sorry,

RE: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-03 Thread Lindenmaier, Goetz
rds, Goetz. > -Original Message- > From: David Holmes [mailto:david.hol...@oracle.com] > Sent: Dienstag, 3. November 2015 11:07 > To: Lindenmaier, Goetz; hotspot-runtime-...@openjdk.java.net; > serviceability-dev > Subject: Re: RFR(M): 8140482: Various minor code impr

Re: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-03 Thread David Holmes
Hi Goetz, Quick follow up on a couple of things ... On 3/11/2015 7:33 PM, Lindenmaier, Goetz wrote: Hi David, Sorry, lots of folks very busy at the moment as we try to get features finalized before the deadline. thanks for looking at this! I know the Dec. 10 deadline, but I guess that also

Re: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-03 Thread David Holmes
Oops see what you mean about attachListener_windows.cpp now: if (strlen(arg0) > AttachOperation::arg_length_max) return ATTACH_ERROR_ILLEGALARG; if (strlen(arg0) > AttachOperation::arg_length_max) return ATTACH_ERROR_ILLEGALARG; Should be arg0, arg1 and arg2. David On 3/11/2015 8:07 PM,

RE: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-03 Thread Lindenmaier, Goetz
Hi David, > Sorry, lots of folks very busy at the moment as we try to get features > finalized before the deadline. thanks for looking at this! I know the Dec. 10 deadline, but I guess that also holds for us ... at least J1 is over now. (Unfortunately we could not attend this year.) > > ps_cor

Re: RFR(M): 8140482: Various minor code improvements (runtime)

2015-11-02 Thread David Holmes
(adding serviceability-dev as they own SA code and some other parts - eg SR_signal_num issue) Hi Goetz, Sorry, lots of folks very busy at the moment as we try to get features finalized before the deadline. On 27/10/2015 5:39 PM, Lindenmaier, Goetz wrote: Hi, SAP requires us to fix a row of