RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-05 Thread Dmitry Samersoff
Everyone, Please review the fix: http://cr.openjdk.java.net/~dsamersoff/JDK-8059036/webrev.01/ heap dcmd outputs the same information as SIGBREAK finalizerinfo dcmd outputs a list of all classes in finalization queue with count -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint

Re: RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-05 Thread Staffan Larsen
Dmitry, I think this should be reviewed on hotspot-gc and core-libs-dev as well considering the changes to Finalizer. I’m a little worried about the potentially very large String that is returned from printFinalizationQueue(). A possible different approach would be to write printFinalizationQu

Re: RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-05 Thread Peter Levart
Hi Dmitry, Staffan, On 05/05/2015 12:38 PM, Staffan Larsen wrote: Dmitry, I think this should be reviewed on hotspot-gc and core-libs-dev as well considering the changes to Finalizer. I’m a little worried about the potentially very large String that is returned from printFinalizationQueue().

Re: RFR(M): JDK-8059036 : Implement Diagnostic Commands for heap and finalizerinfo

2015-05-06 Thread Derek White
Hi Dmitry, Staffan, Lots of good comments here. On the topic of what list should be printed out, I think we should focus on objects waiting to be finalized - e.g. the contents of the ReferenceQueue. It's more of a pain to walk the ReferenceQueue, but you could add a summerizeQueue(TreeMap) me