Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Dmitry, Thank you for the update. Good luck with rbt run and push. Thanks, Serguei On 10/5/16 08:48, Dmitry Samersoff wrote: Serguei, This comments above became out-dated now. fixed. (in-place, press shift-reload) Nice. Consider it reviewed. Thanks, Serguei Thank you. I'll run rbt j

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Serguei, > This comments above became out-dated now. fixed. (in-place, press shift-reload) > Nice. Consider it reviewed. Thanks, Serguei Thank you. I'll run rbt job and proceed with push if everything is OK. -Dmitry On 2016-10-05 16:02, serguei.spit...@oracle.com wrote: > Hi Dmitry, > >

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Hi Dmitry, On 10/4/16 05:59, Dmitry Samersoff wrote: Serguei, Exact code executed by original version of this tests depends to what tests was run before: 1. We have to explicitly @build JpsBase to put it into jar file. 2. Couple of testlibrary classes are build because of JpsBase.java depen

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Serguei, Exact code executed by original version of this tests depends to what tests was run before: 1. We have to explicitly @build JpsBase to put it into jar file. 2. Couple of testlibrary classes are build because of JpsBase.java dependency. Jtreg put it to ./JTwork/classes/sun/tools/jps/jdk

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

On 10/4/16 01:36, serguei.spit...@oracle.com wrote: Dmitry, On 10/3/16 05:25, Dmitry Samersoff wrote: Serguei, Thank you for comments. I'll fix it. It is completely unclear what was the exact intention with this fix. It's not the first time I fix this test. It starts failing again as soon

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

On 10/4/16 01:36, serguei.spit...@oracle.com wrote: Dmitry, On 10/3/16 05:25, Dmitry Samersoff wrote: Serguei, Thank you for comments. I'll fix it. It is completely unclear what was the exact intention with this fix. It's not the first time I fix this test. It starts failing again as soon

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Dmitry, On 10/3/16 05:25, Dmitry Samersoff wrote: Serguei, Thank you for comments. I'll fix it. It is completely unclear what was the exact intention with this fix. It's not the first time I fix this test. It starts failing again as soon as something is changed in the environment, testlib o

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Serguei, Thank you for comments. I'll fix it. > It is completely unclear what was the exact intention with this fix. It's not the first time I fix this test. It starts failing again as soon as something is changed in the environment, testlib or jtreg. So provide a stable test is the motivation

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Hi Dmitry, It is completely unclear what was the exact intention with this fix. Could you, please, explain more? What was the refactoring plan? Why four files are removed? Are two new files a replacement of the deleted four files? What functionality was deleted and why and what was moved? htt

RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

(* Resending, Any reviewers? *) Everybody, Please, review: http://cr.openjdk.java.net/~dsamersoff/JDK-8165500/webrev.02/ I refactored the test to improve stability and simplify further debugging. Testing: rbt PS: Diffs is messy, so pleas look at raw files. -Dmitry -- Dmitry Samersoff Oracl

PING Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Any comments? On 2016-09-23 12:01, Dmitry Samersoff wrote: > Everybody, > > Please, review: > > http://cr.openjdk.java.net/~dsamersoff/JDK-8165500/webrev.02/ > > I refactored the test to improve stability and simplify further > debugging. > > Testing: rbt > > PS: Diffs is messy, so pleas look

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Daniel, Thank you! I'll fix it. -Dmitry On 2016-09-23 12:48, Daniel Fuchs wrote: > Hi Dmitry, > > There's a potential bug here. If two directories in the > classpath contains two different versions of A.class, > then the wrong version (the one that comes last) will > be included in the jar: >

Re: RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Hi Dmitry, There's a potential bug here. If two directories in the classpath contains two different versions of A.class, then the wrong version (the one that comes last) will be included in the jar: LingeredAppForJps::buildJar 109 for (String path : testClassPath.split(File.pathSeparat

RFR(M): JDK-8165500: TestJpsJar shouldn't jar all test.classpath directories

Everybody, Please, review: http://cr.openjdk.java.net/~dsamersoff/JDK-8165500/webrev.02/ I refactored the test to improve stability and simplify further debugging. Testing: rbt PS: Diffs is messy, so pleas look at raw files. -Dmitry -- Dmitry Samersoff Oracle Java development team, Saint Pe