Re: RFR(S): 8008102: SA on OS X does not stop the attached process

2013-02-14 Thread Staffan Larsen
On 14 feb 2013, at 11:40, David Holmes david.hol...@oracle.com wrote: On 14/02/2013 1:05 AM, Staffan Larsen wrote: Please review the following change. When SA attaches to a JVM on OS X, it does not stop the process. If the JVM keeps running while SA inspects it can lead to all kinds of

RFR(S): 8008102: SA on OS X does not stop the attached process

2013-02-13 Thread Staffan Larsen
Please review the following change. When SA attaches to a JVM on OS X, it does not stop the process. If the JVM keeps running while SA inspects it can lead to all kinds of inconsistencies in SA. The proposed solution uses ptrace to attach to the process to keep it from running. Ptrace works a

Re: RFR(S): 8008102: SA on OS X does not stop the attached process

2013-02-13 Thread Rickard Bäckman
Staffan, nice work. Looks good to me. (Not a Reviewer). /R 13 feb 2013 kl. 16:05 skrev Staffan Larsen staffan.lar...@oracle.com: Please review the following change. When SA attaches to a JVM on OS X, it does not stop the process. If the JVM keeps running while SA inspects it can lead to