Hi,
here is the updated webrev containing Dans suggested changes.
I also had to change the assert check in os::malloc, we discovered it wasn't
safe to check Thread::current() since os::malloc() can be called when the
libjvm is loaded / initialized and we don't have a thread yet.
Changing to
http://cr.openjdk.java.net/~rbackman/8020701.1/
Thumbs up!
src/os/posix/vm/os_posix.cpp
Can you reformat the new lines that are over 80 cols?
No need to re-review that change if you do it.
src/os/posix/vm/os_posix.hpp
No comments.
src/os/windows/vm/os_windows.cpp
The
On 7/18/13 7:58 AM, Rickard Bäckman wrote:
Fixed them all, will start jprt-jobs.
Thanks!
Didn't know we were so strict on the 80 columns, considering all the other code
in those files… :)
Most folks aren't, but I prefer that we don't add to the problem
when we add new code.
I personally
Fixed them all, will start jprt-jobs.
Didn't know we were so strict on the 80 columns, considering all the other code
in those files… :)
Thanks
/R
On Jul 18, 2013, at 3:09 PM, Daniel D. Daugherty wrote:
http://cr.openjdk.java.net/~rbackman/8020701.1/
Thumbs up!
On 7/17/13 5:58 AM, Rickard Bäckman wrote:
Hi all,
can I please have reviews for the following change?
We are adding a mechanism for avoiding some crashes in the WatcherThread using
different OS-specific methods.
Webrev: http://cr.openjdk.java.net/~rbackman/8020701/webrev/
Thanks
/R
On Jul 17, 2013, at 7:03 PM, Daniel D. Daugherty wrote:
On 7/17/13 5:58 AM, Rickard Bäckman wrote:
Hi all,
can I please have reviews for the following change?
We are adding a mechanism for avoiding some crashes in the WatcherThread
using different OS-specific methods.
Webrev:
