Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-09-01 Thread serguei.spit...@oracle.com
Thanks, Dmitry! Serguei On 9/1/16 03:55, Dmitry Samersoff wrote: Serguei, OK. Closing as a dup. -Dmitry On 2016-09-01 13:40, serguei.spit...@oracle.com wrote: Hi David, Thank you for the comment. Dmitry, It seems, Chris and David are not comfortable with current fix. Are you Ok to close

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-09-01 Thread Dmitry Samersoff
Serguei, OK. Closing as a dup. -Dmitry On 2016-09-01 13:40, serguei.spit...@oracle.com wrote: > Hi David, > > Thank you for the comment. > > Dmitry, > > It seems, Chris and David are not comfortable with current fix. > Are you Ok to close this bug as a dup? > > Thanks, > Serguei > > > On 8

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-09-01 Thread serguei.spit...@oracle.com
Hi David, Thank you for the comment. Dmitry, It seems, Chris and David are not comfortable with current fix. Are you Ok to close this bug as a dup? Thanks, Serguei On 8/29/16 20:05, David Holmes wrote: Hi Serguei, On 30/08/2016 4:46 AM, serguei.spit...@oracle.com wrote: Chris and David,

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-08-29 Thread David Holmes
Hi Serguei, On 30/08/2016 4:46 AM, serguei.spit...@oracle.com wrote: Chris and David, We had a private discussion about this bug with Dmitry last week. I initially suggested to close it as a dup of JDK-8134103 but then agreed with a fix replacing crash symptom with AGENT_ERROR_INTERNAL. I still

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-08-29 Thread serguei.spit...@oracle.com
Chris and David, We had a private discussion about this bug with Dmitry last week. I initially suggested to close it as a dup of JDK-8134103 but then agreed with a fix replacing crash symptom with AGENT_ERROR_INTERNAL. I still have some doubt if it makes sense, as it does not look as important.

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-08-29 Thread Dmitry Samersoff
Chris & David, JVMTI_ERROR_WRONG_PHASE problem is complicated and requires significant work probably on both JDWP and JVMTI side. Serguei plan to do it as a part of JDK-8134103 and not for JDK 9. So yes, we can close this one as a dup of JDK-8134103 - it has the same root cause and should be addr

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-08-28 Thread Chris Plummer
On 8/28/16 6:14 PM, David Holmes wrote: On 27/08/2016 7:35 AM, Chris Plummer wrote: Hi Dmitry, Although the fix is addressing the specific issue described in the bug, what about the general issue of referencing gdata after a call to cbEarlyVMDeath(). Do more references to gdata need to be prote

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-08-28 Thread David Holmes
On 27/08/2016 7:35 AM, Chris Plummer wrote: Hi Dmitry, Although the fix is addressing the specific issue described in the bug, what about the general issue of referencing gdata after a call to cbEarlyVMDeath(). Do more references to gdata need to be protected? Also, is there the possibility of

Re: RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-08-26 Thread Chris Plummer
Hi Dmitry, Although the fix is addressing the specific issue described in the bug, what about the general issue of referencing gdata after a call to cbEarlyVMDeath(). Do more references to gdata need to be protected? Also, is there the possibility of a multi-threading race condition here? Co

RFR(S): 8163994: Nightly test crashed in jvmtiAllocate

2016-08-26 Thread Dmitry Samersoff
Everybody, Please review the fix. http://cr.openjdk.java.net/~dsamersoff/JDK-8163994/webrev.02/ *Problem* Under some circumstances, when JVMTI_ERROR_WRONG_PHASE(112) is received, jvmtiAllocate could be called after call to cbEarlyVMDeath. cbEarlyVMDeath set gdata->jvmti to NULL, so jvmtiAlloca