Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

I followed up on this just to make sure. It turns out we still do some localizations, but they are handled automatically near the end of the release cycle. So I think the changes are good as-is. thanks, Chris On 2/14/19 6:56 AM, Chris Plummer wrote: Do you mean for the non-english locales?

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

+1 --alex On 02/13/2019 23:07, serguei.spit...@oracle.com wrote: Hi Chris, It looks good to me. Thanks, Serguei On 2/13/19 18:43, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Do you mean for the non-english locales? If I understood correctly what I was told a while back, we don't localize anymore, so it shouldn't be necessary. Chris On 2/14/19 2:11 AM, gary.ad...@oracle.com wrote: Do you need placeholder entries in the translated TTYResources message files? On

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Do you need placeholder entries in the translated TTYResources message files? On 2/13/19 9:43 PM, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941 Tested by running the following on

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Hi Chris, It looks good to me. Thanks, Serguei On 2/13/19 18:43, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941 Tested by running the following on all supported platforms:

Re: RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Hi Chris, It looks good to me. Thanks, Serguei On 2/13/19 18:43, Chris Plummer wrote: Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941 Tested by running the following on all supported platforms:

RFR(S): 8218941: jdb should support a dbgtrace command that acts the same as the dbgtrace command line option

Hi, Please review the following: http://cr.openjdk.java.net/~cjplummer/8218941/webrev https://bugs.openjdk.java.net/browse/JDK-8218941 Tested by running the following on all supported platforms: open/test/hotspot/jtreg/vmTestbase/nsk/jdb open/test/jdk/com/sun/jdi thanks, Chris