RE: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-23 Thread Langer, Christoph
22:24 > To: Langer, Christoph ; > daniel.daughe...@oracle.com; serviceability-dev@openjdk.java.net > Subject: Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of > attach operations > > On 23/03/2018 5:15 AM, Langer, Christoph wrote: > > Hi David, > > > >&g

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-22 Thread David Holmes
On 23/03/2018 5:15 AM, Langer, Christoph wrote: Hi David, I think you should keep your original fix since it now properly handles null arguments at the same attach-on-demand layer as the Linux code that you quoted. Handling this in args array processing would also be possible as David suggests

RE: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-22 Thread Langer, Christoph
Hi David, > > I think you should keep your original fix since it now properly > > handles null arguments at the same attach-on-demand layer as the > > Linux code that you quoted. > > > > Handling this in args array processing would also be possible > > as David suggests, but it would bother me tha

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread David Holmes
or in Java - I'll check it out... Best regards Christoph -Original Message- From: David Holmes [mailto:david.hol...@oracle.com] Sent: Mittwoch, 21. März 2018 10:20 To: Langer, Christoph ; serviceability- d...@openjdk.java.net Subject: Re: RFR(S) 8199924: Solaris: Correctly enqueue nul

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread Daniel D. Daugherty
: Langer, Christoph ; David Holmes ; serviceability-dev@openjdk.java.net Subject: Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations Hmmm... shouldn't the inconsistency in the Solaris backend also be addressed? Dan On 3/21/18 8:45 AM, Langer, Christoph wrote: Hi D

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread Daniel D. Daugherty
März 2018 14:59 To: Langer, Christoph ; David Holmes ; serviceability-dev@openjdk.java.net Subject: Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations Hmmm... shouldn't the inconsistency in the Solaris backend also be addressed? Dan On 3/21/18 8:45

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread Daniel D. Daugherty
[mailto:daniel.daughe...@oracle.com] Sent: Mittwoch, 21. März 2018 14:59 To: Langer, Christoph ; David Holmes ; serviceability-dev@openjdk.java.net Subject: Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations Hmmm... shouldn't the inconsistency in the Solaris backend also be addr

RE: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread Langer, Christoph
penjdk.java.net > Subject: Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of > attach operations > > Hmmm... shouldn't the inconsistency in the Solaris backend also be > addressed? > > Dan > > > On 3/21/18 8:45 AM, Langer, Christoph wrote: &

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread Daniel D. Daugherty
--Original Message- From: David Holmes [mailto:david.hol...@oracle.com] Sent: Mittwoch, 21. März 2018 10:20 To: Langer, Christoph ; serviceability- d...@openjdk.java.net Subject: Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations Hi Christoph, On 21/03/2018 6:10

RE: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread Langer, Christoph
Langer, Christoph ; serviceability- > d...@openjdk.java.net > Subject: Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of > attach operations > > Hi Christoph, > > On 21/03/2018 6:10 PM, Langer, Christoph wrote: > > Hi, > > > > may I please as

Re: RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread David Holmes
Hi Christoph, On 21/03/2018 6:10 PM, Langer, Christoph wrote: Hi, may I please ask for reviews of the following small fix. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8199924.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8199924 If one passes null arguments to the varargs of attac

RFR(S) 8199924: Solaris: Correctly enqueue null arguments of attach operations

2018-03-21 Thread Langer, Christoph
Hi, may I please ask for reviews of the following small fix. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8199924.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8199924 If one passes null arguments to the varargs of attach operations, they get swallowed on Solaris and following argumen