Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Ioi Lam
On 10/22/18 10:25 AM, Lois Foltan wrote: On 10/22/2018 1:49 AM, Ioi Lam wrote: Hi David, Thanks for the review. Updated webrev: http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04/

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread David Holmes
Hi Ioi, Sorry for all the extra work in the test. ;-) The updates look good to me (and I've seen follow up comments). Thanks, David On 22/10/2018 3:49 PM, Ioi Lam wrote: Hi David, Thanks for the review. Updated webrev:

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread serguei.spit...@oracle.com
Okay, thanks! Serguei On 10/22/18 18:49, Ioi Lam wrote: Hi Serguei, Thanks for the review! On 10/22/18 5:09 PM, serguei.spit...@oracle.com wrote: Hi Ioi, It looks good to me.

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Ioi Lam
Hi Serguei, Thanks for the review! On 10/22/18 5:09 PM, serguei.spit...@oracle.com wrote: Hi Ioi, It looks good to me. Some minor questions below.

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Jiangli Zhou
Sounds good. Thanks for trying that. Thanks, Jiangli > On Oct 22, 2018, at 6:43 PM, Ioi Lam wrote: > > > >> On 10/22/18 3:06 PM, Jiangli Zhou wrote: >>> On 10/22/18 10:56 AM, Ioi Lam wrote: >>> >>> >>> On 10/22/18 10:25 AM, Jiangli Zhou wrote: Hi Ioi, Looks good.

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Ioi Lam
On 10/22/18 3:06 PM, Jiangli Zhou wrote: On 10/22/18 10:56 AM, Ioi Lam wrote: On 10/22/18 10:25 AM, Jiangli Zhou wrote: Hi Ioi, Looks good. Please see comments below. - src/hotspot/share/classfile/javaClasses.cpp 4254 assert(JvmtiEnvBase::get_phase() <= JVMTI_PHASE_PRIMORDIAL,

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread serguei.spit...@oracle.com
Hi Ioi, It looks good to me. Some minor questions below. http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04/src/hotspot/share/classfile/systemDictionary.hpp.frames.html 706 // Resolve well_known classes so they

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Jiangli Zhou
On 10/22/18 10:56 AM, Ioi Lam wrote: On 10/22/18 10:25 AM, Jiangli Zhou wrote: Hi Ioi, Looks good. Please see comments below. - src/hotspot/share/classfile/javaClasses.cpp 4254 assert(JvmtiEnvBase::get_phase() <= JVMTI_PHASE_PRIMORDIAL, 4255    "Field offsets of well-known

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Jiangli Zhou
On 10/21/18 6:15 PM, Ioi Lam wrote: Re-sending to the correct mailing lists. Please disregard the other email. http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v03/ https://bugs.openjdk.java.net/browse/JDK-8212200 Hi, CDS has various built-in assumptions

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Ioi Lam
On 10/22/18 10:25 AM, Jiangli Zhou wrote: Hi Ioi, Looks good. Please see comments below. - src/hotspot/share/classfile/javaClasses.cpp 4254 assert(JvmtiEnvBase::get_phase() <= JVMTI_PHASE_PRIMORDIAL, 4255    "Field offsets of well-known classes must be computed in

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Lois Foltan
On 10/22/2018 1:49 AM, Ioi Lam wrote: Hi David, Thanks for the review. Updated webrev: http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04/ http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04.delta/ Hi Ioi, Looks good.  A

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-22 Thread Jiangli Zhou
Hi Ioi, Looks good. Please see comments below. - src/hotspot/share/classfile/javaClasses.cpp 4254 assert(JvmtiEnvBase::get_phase() <= JVMTI_PHASE_PRIMORDIAL, 4255    "Field offsets of well-known classes must be computed in JVMTI_PHASE_PRIMORDIAL or before"); Maybe it is worth

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-21 Thread Ioi Lam
Hi David, Thanks for the review. Updated webrev: http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04/ http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v04.delta/ More comments below: On 10/21/18 6:57 PM, David Holmes wrote: Hi

Re: RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-21 Thread David Holmes
Hi Ioi, Generally seems okay. On 22/10/2018 11:15 AM, Ioi Lam wrote: Re-sending to the correct mailing lists. Please disregard the other email. http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v03/ https://bugs.openjdk.java.net/browse/JDK-8212200 Hi, CDS

RFR(S) 8212200 assert when shared java.lang.Object is redefined by JVMTI agent

2018-10-21 Thread Ioi Lam
Re-sending to the correct mailing lists. Please disregard the other email. http://cr.openjdk.java.net/~iklam/jdk12/8212200-cds-jvmti-clfh-critical-classes.v03/ https://bugs.openjdk.java.net/browse/JDK-8212200 Hi, CDS has various built-in assumptions that classes loaded by