Looks good.
StefanK
On 2020-04-25 00:30, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00
8 lines changed: 0 ins; 6 del; 2 mod;
Hi all,
could you please review this small and trivial patch which updates
serviceability/logging/TestLogRotation.java test to pass bo
David, Leonid,
thank you for review, pushed.
-- Igor
> On Apr 26, 2020, at 3:38 PM, David Holmes wrote:
>
> On 25/04/2020 11:51 pm, Igor Ignatev wrote:
>> Thanks Chris. I can’t help but wonder if we should move all tests from
>> serviceability/logging to runtime then.
>
> Actually unified log
On 25/04/2020 11:51 pm, Igor Ignatev wrote:
Thanks Chris. I can’t help but wonder if we should move all tests from
serviceability/logging to runtime then.
Actually unified logging (JEP 158) was defined as a serviceability feature:
https://bugs.openjdk.java.net/browse/JDK-8046148
IIUC the cor
Thanks Chris. I can’t help but wonder if we should move all tests from
serviceability/logging to runtime then.
— Igor
> On Apr 24, 2020, at 3:53 PM, Chris Plummer wrote:
>
> Adding hotspot-runtime-dev since logging is owned by runtime, not
> serviceability.
>
> Chris
>
>> On 4/24/20 3:41
Adding hotspot-runtime-dev since logging is owned by runtime, not
serviceability.
Chris
On 4/24/20 3:41 PM, Leonid Mesnik wrote:
Looks good. (Need a 'R'eview.)
Leonid.
On Apr 24, 2020, at 3:30 PM, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00
8 lines chang
Looks good. (Need a 'R'eview.)
Leonid.
> On Apr 24, 2020, at 3:30 PM, Igor Ignatyev wrote:
>
> http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00
>> 8 lines changed: 0 ins; 6 del; 2 mod;
>
> Hi all,
>
> could you please review this small and trivial patch which updates
> serviceabilit
http://cr.openjdk.java.net/~iignatyev//8243568/webrev.00
> 8 lines changed: 0 ins; 6 del; 2 mod;
Hi all,
could you please review this small and trivial patch which updates
serviceability/logging/TestLogRotation.java test to pass both 'test.java.opts'
and not 'test.vm.opts' ? to do that, the pa
