RFR(XL) : 8199383 : [TESTBUG] Open source VM testbase JVMTI tests

2018-05-22 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8199383/webrev.00/index.html > 308253 lines changed: 308253 ins; 0 del; 0 mod; Hi all, could you please review this patch which open sources JVMTI tests from VM testbase? As usually w/ VM testbase code, these tests are old, they have been run in hotspot t

Re: RFR(XL) : 8199383 : [TESTBUG] Open source VM testbase JVMTI tests

2018-05-22 Thread Erik Joelsson
Looks like the line "# } nsk/jvmti" is a left over. Otherwise this looks ok, even if it's an enormous amount of duplication. Hopefully we can figure out a better way to express common parameters for tests soon. /Erik On 2018-05-22 16:35, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iigna

Re: RFR(XL) : 8199383 : [TESTBUG] Open source VM testbase JVMTI tests

2018-05-24 Thread serguei.spit...@oracle.com
Hi Igor, It looks good to me. Thanks, Serguei On 5/22/18 16:35, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8199383/webrev.00/index.html 308253 lines changed: 308253 ins; 0 del; 0 mod; Hi all, could you please review this patch which open sources JVMTI tests from VM testba

Re: RFR(XL) : 8199383 : [TESTBUG] Open source VM testbase JVMTI tests

2018-05-25 Thread Magnus Ihse Bursie
On 2018-05-23 02:05, Erik Joelsson wrote: Looks like the line "# } nsk/jvmti" is a left over. Otherwise this looks ok, even if it's an enormous amount of duplication. Hopefully we can figure out a better way to express common parameters for tests soon. Argee, the current solution is not scaling