Re: RFR(XS): 6721425: JConsole Makefile clean rule is missing rm of generated Version.java

2013-08-12 Thread Alan Bateman
On 06/08/2013 20:47, Erik Gahlin wrote: Without this change a 'gmake clean' in the jdk/make/sun/jconsole directory does not properly clean up the build results. Bug: http://monaco.us.oracle.com/detail.jsf?cr=6721425 Webrev: http://cr.openjdk.java.net/~egahlin/6721425/ Thanks Erik The change l

Re: RFR(XS): 6721425: JConsole Makefile clean rule is missing rm of generated Version.java

2013-08-12 Thread Staffan Larsen
Looks good. /Staffan On 6 aug 2013, at 21:47, Erik Gahlin wrote: > Without this change a 'gmake clean' in the jdk/make/sun/jconsole directory > does not properly clean up the build results. > > Bug: > http://monaco.us.oracle.com/detail.jsf?cr=6721425 > > Webrev: > http://cr.openjdk.java.net/

Re: RFR(XS): 6721425: JConsole Makefile clean rule is missing rm of generated Version.java

2013-08-07 Thread Jaroslav Bachorik
Looks fine (not a reviewer) -JB- On 08/06/2013 09:47 PM, Erik Gahlin wrote: > Without this change a 'gmake clean' in the jdk/make/sun/jconsole > directory does not properly clean up the build results. > > Bug: > http://monaco.us.oracle.com/detail.jsf?cr=6721425 > > Webrev: > http://cr.openjdk.j

RFR(XS): 6721425: JConsole Makefile clean rule is missing rm of generated Version.java

2013-08-06 Thread Erik Gahlin
Without this change a 'gmake clean' in the jdk/make/sun/jconsole directory does not properly clean up the build results. Bug: http://monaco.us.oracle.com/detail.jsf?cr=6721425 Webrev: http://cr.openjdk.java.net/~egahlin/6721425/ Thanks Erik