I see - thanks!
> On 8 apr. 2016, at 11:54, Dmitry Samersoff
> wrote:
>
> Staffan,
>
> I suspect its because of root/non-root. OS X attach doesn't work for
> non-root user. Test check it and skips silently. But if the test run
> under root, it tries to run and then fail.
>
> -Dmitry
>
> On 2
Dmitry,
+ System.err.println("This test is not expected to work on OS X.
Skipping"); I think, it has to be System.out, not System err (the same
as at L107). No need to re-review if you fix it. Thanks, Serguei
On 4/8/16 03:01, Dmitry Samersoff wrote:
Tim, Serguei,
Thank you for the review.
Tim, Serguei,
Thank you for the review.
The message updated (in-place, press shift-reload)
http://cr.openjdk.java.net/~dsamersoff/JDK-8152679/webrev.01/
-Dmitry
On 2016-04-07 21:35, serguei.spit...@oracle.com wrote:
> Dmitry,
>
> I agree with Tim.
> The message at L85 should not be alarming b
Staffan,
I suspect its because of root/non-root. OS X attach doesn't work for
non-root user. Test check it and skips silently. But if the test run
under root, it tries to run and then fail.
-Dmitry
On 2016-04-08 11:10, Staffan Larsen wrote:
> Why did this test start failing?
>
>> On 7 apr. 2016
Why did this test start failing?
> On 7 apr. 2016, at 20:35, serguei.spit...@oracle.com wrote:
>
> Dmitry,
>
> I agree with Tim.
> The message at L85 should not be alarming but look similar to the one at L107.
> Something, like this:
> 85System.out.println("This test is not expected to
Dmitry,
I agree with Tim.
The message at L85 should not be alarming but look similar to the one at
L107.
Something, like this:
85System.out.println("This test is not expected to work on OS
X. Skipping");
Thanks,
Serguei
On 4/7/16 11:13, Tim Bell wrote:
On 04/07/16 10:56, Dmitry
On 04/07/16 10:56, Dmitry Samersoff wrote:
Everybody,
Please review small changes.
Note: I am not a "R"eviewer in Serviceability. Free advice follows:
http://cr.openjdk.java.net/~dsamersoff/JDK-8152679/webrev.01/
Test that is not expected to work on OS X, detect OS X and exits.
84
Everybody,
Please review small changes.
http://cr.openjdk.java.net/~dsamersoff/JDK-8152679/webrev.01/
Test that is not expected to work on OS X, detect OS X and exits.
-Dmitry
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but th
