Re: RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

2018-09-21 Thread Alex Menkov
+1 --alex On 09/21/2018 14:19, JC Beyler wrote: Hi Chris, Looks good to me! Thanks, Jc On Fri, Sep 21, 2018 at 1:47 PM Chris Plummer > wrote: Hi, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8210987 http://cr.openj

Re: RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

2018-09-21 Thread Chris Plummer
Thanks David and JC! On 9/21/18 2:57 PM, David Holmes wrote: Looks fine. Thanks, David On 21/09/2018 4:46 PM, Chris Plummer wrote: Hi, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8210987 http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/ Here's an example of

Re: RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

2018-09-21 Thread David Holmes
Looks fine. Thanks, David On 21/09/2018 4:46 PM, Chris Plummer wrote: Hi, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8210987 http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/ Here's an example of some "before" output on windows: Sending command: cont repl

RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests

2018-09-21 Thread Chris Plummer
Hi, Please review the following: https://bugs.openjdk.java.net/browse/JDK-8210987 http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/ Here's an example of some "before" output on windows: Sending command: cont reply[0]: > reply[1]: Method entered: "thread=MyThread-1", java.util.Locale.g