RE: RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics

2016-03-03 Thread Markus Gronlund
Thanks Dmitry for noticing this - I am running slowdebug so I didn't see that. Thanks again. Markus From: Dmitry Dmitriev Sent: den 3 mars 2016 12:23 To: Markus Gronlund; serviceability-dev@openjdk.java.net Subject: Re: RFR(XXS): 8151100: Test java/lang/instr

Re: RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics

2016-03-03 Thread Dmitry Dmitriev
Hello Markus, CheckIntrinsics is a diagnostic flag. I think you need to add -XX:+UnlockDiagnosticVMOptions before it because otherwise test will fail on product build. Thanks, Dmitry On 03.03.2016 3:15, Markus Gronlund wrote: Greetings, Could a please ask for reviews for the following sim

RE: RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics

2016-03-03 Thread Markus Gronlund
Thank you Serguei! Markus From: Serguei Spitsyn Sent: den 3 mars 2016 10:18 To: Markus Gronlund; serviceability-dev@openjdk.java.net Subject: Re: RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics Hi Markus, The fix

Re: RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics

2016-03-03 Thread serguei.spit...@oracle.com
Hi Markus, The fix looks good. Thanks, Serguei On 3/2/16 16:15, Markus Gronlund wrote: Greetings, Could a please ask for reviews for the following simple fix to resolve a test issue associated with test/java/lang/instrument/NativeMethodPrefixAgent.java Bug: https://bugs.openjdk.java.net

Re: RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics

2016-03-02 Thread Erik Gahlin
Looks good! Erik Den 03/03/16 kl. 01:15, skrev Markus Gronlund: Greetings, Could a please ask for reviews for the following simple fix to resolve a test issue associated with test/java/lang/instrument/NativeMethodPrefixAgent.java Bug: https://bugs.openjdk.java.net/browse/JDK-8151100 Webr

RFR(XXS): 8151100: Test java/lang/instrument/NativeMethodPrefixAgent.java can't attempt to do CheckIntrinsics

2016-03-02 Thread Markus Gronlund
Greetings, Could a please ask for reviews for the following simple fix to resolve a test issue associated with test/java/lang/instrument/NativeMethodPrefixAgent.java Bug: https://bugs.openjdk.java.net/browse/JDK-8151100 Webrev/diff: diff --git a/test/java/lang/instrument/NativeMet