Ah, was just about to take a look a this too!
Looks good and equal to what I had in my workspace :)
/Nisse
On Jan 31, 2013, at 8:16 , Yumin Qi yumin...@oracle.com wrote:
Please have your comments on:
http://cr.openjdk.java.net/~minqi/8000973/
This only affected Windows platform.
Thanks, Nils
Yumin
On 1/31/2013 12:12 AM, Nils Loodin wrote:
Ah, was just about to take a look a this too!
Looks good and equal to what I had in my workspace :)
/Nisse
On Jan 31, 2013, at 8:16 , Yumin Qiyumin...@oracle.com wrote:
Please have your comments on:
Hi Yumin,
Looks good.
A couple of minor comments.
1. All the copyright comments are outdated.
2.
*agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java
***agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/x86/WindbgX86Thread.java
**
37 //The address
Serguei,
Thanks
Yumin
On 1/31/2013 11:10 AM, serguei.spit...@oracle.com wrote:
Hi Yumin,
Looks good.
A couple of minor comments.
1. All the copyright comments are outdated.
2.
*
agent/src/share/classes/sun/jvm/hotspot/debugger/windbg/amd64/WindbgAMD64Thread.java
***
Please have your comments on:
http://cr.openjdk.java.net/~minqi/8000973/
This only affected Windows platform.
Summary: After bug 7161732, On Windows SA could not find correct address
of thread_id of OSThread since _thread_id moved to end of the class .
The presupposition of the address is
