Hi,
Please review the following change for CR 8004095.
This changeset is the JDK side of two parts project.
The goal of this feature is to allow remote invocations of
Diagnostic Commands via JMX.
Diagnostic Commands are actually invoked from the jcmd
tool, which is a local tool using the atta
Frederic,
Looks good! Just a few small comments below.
diagnosticCommand.cpp:255: When DisableExplicitGC is set, it would be great if
the SystemGC command printed on error message so that the caller knows that the
GC didn't happen as intended. I also think we should add an entry to GCCause
for
Staffan,
Thank you for the review, I've fixed the code to address all
the issue you reported. The new webrev is here:
http://cr.openjdk.java.net/~fparain/8004095/webrev.01/
Regards,
Fred
On 12/17/12 01:27 PM, Staffan Larsen wrote:
Frederic,
Looks good! Just a few small comments below.
diag
diagnosticCommand.cpp:259: nit: wrong indentation
Otherwise: Looks good to me!
Thanks,
/Staffan
On 17 dec 2012, at 16:01, Frederic Parain wrote:
> Staffan,
>
> Thank you for the review, I've fixed the code to address all
> the issue you reported. The new webrev is here:
>
> http://cr.openjdk
Frederic,
Finally getting to a code review. I like the design and the code looks very
clean.
I had a couple of questions please:
1. in the EFP and diagnosticCommand.hpp, why do GC.run and GC. run_finalization
not need any special Java permissions?
Is this backward compatibility with existing w
Karen,
Thanks for the review, new webrevs are available here:
8004095:
http://cr.openjdk.java.net/~fparain/8004095/webrev.05/
7150256:
http://cr.openjdk.java.net/~fparain/7150256/webrev.05/
My answers to your questions are in-lined below:
On 10/01/2013 21:28, Karen Kinnear wrote:
1. in the E
