Staffan,
the change looks good to me! Thanks for fixing this problem.
/R
On Jan 17, 2013, at 8:48 PM, Staffan Larsen wrote:
> This is a request for review of a fix for SA on OS X.
>
> webrev: http://cr.openjdk.java.net/~sla/8006423/webrev.00/
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?
On 1 feb 2013, at 18:55, Yumin Qi wrote:
> Staffan,
>
> This looks good. One question is why not set it to _thread_id? is it because
> it is 64bit int and on other platforms 32 bits?
Do you mean reusing the _thread_id field instead of adding a new field? I think
we need the current value o
Staffan,
This looks good. One question is why not set it to _thread_id? is it
because it is 64bit int and on other platforms 32 bits?
os_bsd.cpp:
858 #ifdef __APPLE__
859 osthread->set_thread_id(::mach_thread_self());
860 osthread->set_unique_thread_id(locate_unique_thread_id());
8
Thanks David!
/Staffan
On 1 feb 2013, at 06:05, David Holmes wrote:
> Hi Staffan,
>
> First, please refrain from doing code cleanup (long line reformatting)
> alongside a fairly significant change - it makes the true changes harder to
> spot. Thanks.
>
> Based on our discussions this all lo
Hi Staffan,
First, please refrain from doing code cleanup (long line reformatting)
alongside a fairly significant change - it makes the true changes harder
to spot. Thanks.
Based on our discussions this all looks good to me.
Thanks,
David
On 18/01/2013 5:48 AM, Staffan Larsen wrote:
This i
This is a request for review of a fix for SA on OS X.
webrev: http://cr.openjdk.java.net/~sla/8006423/webrev.00/
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8006423
The bug report contains a detailed description of the problem and the proposed
solution. I have copied some of that tex
