RFR: 8041626: [Event Request] Shutdown reason

Hi all, Please review the following change that adds an event-based tracing event that is generated when the VM shuts down. The intent is to capture shutdowns that occur after the VM has been properly initialized (as initialization problems would most likely mean that the tracing framework hasn

Re: RFR: 8041626: [Event Request] Shutdown reason

On 07/02/2018 15:18, Robin Westberg wrote: Hi all, Please review the following change that adds an event-based tracing event that is generated when the VM shuts down. The intent is to capture shutdowns that occur after the VM has been properly initialized (as initialization problems would mos

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, I can sponsor this. I wonder if we should change the name of the event to "Shutdown" instead? It will give us flexibility to add other shutdown related fields in the future. Could you change the label and field to "Status Code" and statusCode. Event fields should have headline-st

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Alan, > On 7 Feb 2018, at 16:30, Alan Bateman wrote: > > On 07/02/2018 15:18, Robin Westberg wrote: >> Hi all, >> >> Please review the following change that adds an event-based tracing event >> that is generated when the VM shuts down. The intent is to capture shutdowns >> that occur after

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, Adding in hotspot-runtime-dev as all the hotspot changes belong to runtime. I had an initial look through this. To be honest I don't like it. We seem to have to record little bits of information all over the place just so they can be reported by the shutdown event. It seems untidy.

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi David, > On 8 Feb 2018, at 04:28, David Holmes wrote: > > Hi Robin, > > Adding in hotspot-runtime-dev as all the hotspot changes belong to runtime. Thanks, sorry about that.. > I had an initial look through this. > > To be honest I don't like it. We seem to have to record little bits of

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, On 9/02/2018 1:50 AM, Robin Westberg wrote: Hi David, On 8 Feb 2018, at 04:28, David Holmes wrote: Hi Robin, Adding in hotspot-runtime-dev as all the hotspot changes belong to runtime. Thanks, sorry about that.. I had an initial look through this. To be honest I don't like it

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Erik, > On 7 Feb 2018, at 21:47, Erik Gahlin wrote: > > Hi Robin, > > I can sponsor this. > > I wonder if we should change the name of the event to "Shutdown" instead? It > will give us flexibility to add other shutdown related fields in the future. Makes sense, I’ll rename it. > Could y

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi David, > On 9 Feb 2018, at 05:22, David Holmes wrote: > > Hi Robin, > >> Right, almost all the runtime changes are made in order to try to figure out >> what the process exit code from the launcher will eventually be. For >> example, the launcher returns 1 if the main thread exited with an

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, On 10/02/2018 1:41 AM, Robin Westberg wrote: Hi David, On 9 Feb 2018, at 05:22, David Holmes > wrote: Hi Robin, Right, almost all the runtime changes are made in order to try to figure out what the process exit code from the launcher will eventuall

Re: RFR: 8041626: [Event Request] Shutdown reason

On 12/02/2018 07:07, David Holmes wrote: Okay, I’ve removed the code related to the status field, certainly makes the change a bit less intrusive. Updated webrev: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.01/ Incremental: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.00-01

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Alan, > On 12 Feb 2018, at 09:02, Alan Bateman wrote: > > > > On 12/02/2018 07:07, David Holmes wrote: >> >>> Okay, I’ve removed the code related to the status field, certainly makes >>> the change a bit less intrusive. >>> >>> Updated webrev: http://cr.openjdk.java.net/~rwestberg/804162

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi David, > On 12 Feb 2018, at 08:07, David Holmes wrote: > > Hi Robin, > > On 10/02/2018 1:41 AM, Robin Westberg wrote: >> Hi David, >>> On 9 Feb 2018, at 05:22, David Holmes >> >> >> wrote: >>>

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, It looks like the status argument to BeforeHalt is discarded in JVM_BeforeHalt and is not inserted into the event. That suggests it should be removed all the way back to Shutdown.beforeHalt. Roger On 2/13/2018 9:59 AM, Robin Westberg wrote: Hi Alan, On 12 Feb 2018, at 09:02, Al

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Roger, > On 13 Feb 2018, at 16:17, Roger Riggs wrote: > > Hi Robin, > > It looks like the status argument to BeforeHalt is discarded in JVM_BeforeHalt > and is not inserted into the event. > That suggests it should be removed all the way back to Shutdown.beforeHalt. You are right, my thinki

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi again, Here’s the (hopefully) final version: Full: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.02/ Incremental: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.01-02/

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, Looks fine to me. (How is this tested?, Normal, exceptional, etc.) Thanks, Roger On 2/15/2018 8:35 AM, Robin Westberg wrote: Hi again, Here’s the (hopefully) final version: Full: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.02/

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Robin, Do you want a shutdown event for every call to Runtime::exit regardless where it is in the shutdown sequence?  or do you expect to get an event of the first thread calling JVM_Halt?  or the first thread starting the shutdown sequence but it may not be the thread halting? Mandy On

Re: RFR: 8041626: [Event Request] Shutdown reason

Looks fine to me. Thanks, David - On 15/02/2018 11:35 PM, Robin Westberg wrote: Hi again, Here’s the (hopefully) final version: Full: http://cr.openjdk.java.net/~rwestberg/8041626/webrev.02/ Incremental: http://cr.openjdk.java.ne

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Roger, > On 15 Feb 2018, at 17:00, Roger Riggs wrote: > > Hi Robin, > > Looks fine to me. Thanks for reviewing! > (How is this tested?, Normal, exceptional, etc.) The tests are part of the (currently closed) JFR tests. Best regards, Robin > > Thanks, Roger > > > On 2/15/2018 8:35 AM

Re: RFR: 8041626: [Event Request] Shutdown reason

Hi Mandy, > On 15 Feb 2018, at 20:10, mandy chung wrote: > > Hi Robin, > > Do you want a shutdown event for every call to Runtime::exit regardless where > it is in the shutdown sequence? or do you expect to get an event of the > first thread calling JVM_Halt? or the first thread starting th