Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

: Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows Katja, I intentionally did not include javaoptions when launching the new JVMs since I could not think of any options that would affect how -agentlib:jdwp=suspend=y|n

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

Message - > From: daniel.daughe...@oracle.com > To: staffan.lar...@oracle.com > Cc: serviceability-dev@openjdk.java.net > Sent: Tuesday, July 1, 2014 3:37:38 PM GMT +01:00 Amsterdam / Berlin / Bern / > Rome / Stockholm / Vienna > Subject: Re: RFR: 8046883 com/sun/jdi/Pro

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

y-dev@openjdk.java.net Sent: Tuesday, July 1, 2014 3:37:38 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows On 6/23/14 2:33 AM, Staff

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

On 6/23/14 2:33 AM, Staffan Larsen wrote: Fancy! new review: http://cr.openjdk.java.net/~sla/8046883/webrev.01/ test/com/sun/jdi/ProcessAttachTest.java New test looks very good. There's a couple of really long lines, but I can't t

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

Staffan, Looks good for me. -Dmitry On 2014-07-01 15:44, Staffan Larsen wrote: > I’m still looking for a Review of this test code. > > Thanks, > /Staffan > > On 23 jun 2014, at 10:33, Staffan Larsen > wrote: > >> Fancy! >> >> new review: http://cr.openjdk.j

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

I’m still looking for a Review of this test code. Thanks, /Staffan On 23 jun 2014, at 10:33, Staffan Larsen wrote: > Fancy! > > new review: http://cr.openjdk.java.net/~sla/8046883/webrev.01/ > > /Staffan > > On 18 jun 2014, at 13:59, Peter Allwin wrote: > >> This looks a lot better! >> >>

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

Fancy! new review: http://cr.openjdk.java.net/~sla/8046883/webrev.01/ /Staffan On 18 jun 2014, at 13:59, Peter Allwin wrote: > This looks a lot better! > > (Since we’re using fancy new features we could use streams to find the > connector instance) > > AttachingConnector ac = > Boo

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

This looks a lot better! (Since we’re using fancy new features we could use streams to find the connector instance) AttachingConnector ac = Bootstrap.virtualMachineManager().attachingConnectors() .stream() .filter(c -> c.name().equals("com.sun.jdi.ProcessAttach")

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

Here is a rewrite of the test in Java instead of a shell script. Should be easier to maintain. webrev: http://cr.openjdk.java.net/~sla/8046883/webrev.00/ Thanks, /Staffan On 17 jun 2014, at 15:12, Staffan Larsen wrote: > > On 17 jun 2014, at 15:03, Alan Bateman wrote: > >> On 17/06/2014 13

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

On 17 jun 2014, at 15:03, Alan Bateman wrote: > On 17/06/2014 13:35, Staffan Larsen wrote: >> : >> >> It could be a timing issue, but in the other direction. If cygwin hasn’t yet >> started the real windows process when I run ps, then maybe ps will not list >> it. But given the “sleep 2” befo

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

On 17/06/2014 13:35, Staffan Larsen wrote: : It could be a timing issue, but in the other direction. If cygwin hasn’t yet started the real windows process when I run ps, then maybe ps will not list it. But given the “sleep 2” before the ps invocation, the process should have had time to start

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

On 17 jun 2014, at 11:45, Alan Bateman wrote: > On 17/06/2014 09:24, Staffan Larsen wrote: >> This is yet another fallout of the bug in the ps command in cygwin that >> causes it to sometimes miss process in the list. >> >> In this case I cannot use jps to list the processes since one of the t

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

On 17 jun 2014, at 11:56, Dmitry Samersoff wrote: > Staffan, > > As we need windows pid it might be better to try native windows commands > instead of cygwin ps: > > tasklist I tried this, but since it does not list the command line it’s not possible to identify the process I am looking for.

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

Staffan, As we need windows pid it might be better to try native windows commands instead of cygwin ps: tasklist wmic process get Processid,Executablepath -Dmitry On 2014-06-17 12:24, Staffan Larsen wrote: > This is yet another fallout of the bug in the ps command in cygwin that > causes it

Re: RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

On 17/06/2014 09:24, Staffan Larsen wrote: This is yet another fallout of the bug in the ps command in cygwin that causes it to sometimes miss process in the list. In this case I cannot use jps to list the processes since one of the test cases launches jdwp with suspend=y which suspends the VM

RFR: 8046883 com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows

This is yet another fallout of the bug in the ps command in cygwin that causes it to sometimes miss process in the list. In this case I cannot use jps to list the processes since one of the test cases launches jdwp with suspend=y which suspends the VM before it is visible to jps. Instead I retr