Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Thanks Erik! > On 10 aug 2015, at 12:52, Erik Joelsson wrote: > > Looks good to me. > > /Erik > > On 2015-08-07 08:57, Staffan Larsen wrote: >> Please review the following changes to remove the hprof JVMTI agent. There >> are changes in three different repositories. All tests that used the hp

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Looks good to me. /Erik On 2015-08-07 08:57, Staffan Larsen wrote: Please review the following changes to remove the hprof JVMTI agent. There are changes in three different repositories. All tests that used the hprof agent has been removed in previous changesets. Note: This does not remove t

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

> On 9 aug 2015, at 05:13, Mandy Chung wrote: > > >> On Aug 6, 2015, at 11:57 PM, Staffan Larsen >> wrote: >> >> Please review the following changes to remove the hprof JVMTI agent. There >> are changes in three different repositories. All tests that used the hprof >> agent has been remove

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

> On Aug 6, 2015, at 11:57 PM, Staffan Larsen wrote: > > Please review the following changes to remove the hprof JVMTI agent. There > are changes in three different repositories. All tests that used the hprof > agent has been removed in previous changesets. > > Note: This does not remove the

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Ok. Thanks, Staffan! Serguei On 8/7/15 2:27 AM, Staffan Larsen wrote: On 7 aug 2015, at 11:24, serguei.spit...@oracle.com wrote: Hi Staffan, Looks good. Thanks! I'm re-posting the same question in this review: Q1: Should the folder jdk/src/demo/s

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Dmitry, On 8/7/15 2:31 AM, Dmitry Samersoff wrote: Serguei, Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be removed? Yes. See https://bugs.openjdk.java.net/browse/JDK-8041639 Thank you for the comment. But, please, see also the related comment from Staffan. Thanks,

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Serguei, > Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be > removed? Yes. See https://bugs.openjdk.java.net/browse/JDK-8041639 -Dmitry On 2015-08-07 12:24, serguei.spit...@oracle.com wrote: > Hi Staffan, > > Looks good. > > I'm re-posting the same question in this review

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

> On 7 aug 2015, at 11:24, serguei.spit...@oracle.com wrote: > > Hi Staffan, > > Looks good. Thanks! > > I'm re-posting the same question in this review: > Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be > removed? No, it is used by some of the demos (mtrace, minst, e

Re: RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Hi Staffan, Looks good. I'm re-posting the same question in this review: Q1: Should the folder jdk/src/demo/share/jvmti/java_crw_demo also be removed? Thanks, Serguei On 8/6/15 11:57 PM, Staffan Larsen wrote: Please review the following changes to remove the hprof JVMTI agent. There are

RFR: 8076470 - JEP 240: Remove the JVM TI hprof Agent

Please review the following changes to remove the hprof JVMTI agent. There are changes in three different repositories. All tests that used the hprof agent has been removed in previous changesets. Note: This does not remove the ability of the Hotspot VM to output heap dumps in the hprof format