RFR: 8078601: print_concurrent_locks should be guarded with INCLUDE_SERVICES

2015-04-24 Thread Stefan Karlsson
Hi, Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS. http://cr.openjdk.java.net/~stefank/8078601/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8078601 This code in thread.cpp is guarded by INCLUDE_ALL_GCS: #if INCLUDE_ALL_GCS // Dump concurrent locks Concurre

Re: RFR: 8078601: print_concurrent_locks should be guarded with INCLUDE_SERVICES

2015-04-24 Thread Staffan Larsen
Looks good! Thanks, /Staffan > On 24 apr 2015, at 16:41, Stefan Karlsson wrote: > > Hi, > > Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS. > > http://cr.openjdk.java.net/~stefank/8078601/webrev.01/ > https://bugs.openjdk.java.net/browse/JDK-8078601 > > This code i

RE: RFR: 8078601: print_concurrent_locks should be guarded with INCLUDE_SERVICES

2015-04-24 Thread Markus Gronlund
Looks good! Thanks Markus -Original Message- From: Staffan Larsen Sent: den 24 april 2015 11:09 To: Stefan Karlsson Cc: Serviceability Dev Subject: Re: RFR: 8078601: print_concurrent_locks should be guarded with INCLUDE_SERVICES Looks good! Thanks, /Staffan > On 24 apr 2015, at

Re: RFR: 8078601: print_concurrent_locks should be guarded with INCLUDE_SERVICES

2015-04-24 Thread David Holmes
Looks good. Thanks Stefan. David On 25/04/2015 12:41 AM, Stefan Karlsson wrote: Hi, Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS. http://cr.openjdk.java.net/~stefank/8078601/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8078601 This code in thread.cpp is gu

Re: RFR: 8078601: print_concurrent_locks should be guarded with INCLUDE_SERVICES

2015-04-27 Thread Stefan Karlsson
On 2015-04-24 23:49, David Holmes wrote: Looks good. Thanks Stefan. Thanks, David. StefanK David On 25/04/2015 12:41 AM, Stefan Karlsson wrote: Hi, Please review this patch to fix an incorrect usage of #if INCLUDE_ALL_GCS. http://cr.openjdk.java.net/~stefank/8078601/webrev.01/ https:/