Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Thank you, David! Rachel On 12/22/2015 11:26 PM, David Holmes wrote: Thanks Rachel - looks good. David On 22/12/2015 7:46 AM, Rachel Protacio wrote: Hi, Please take a look at my updated changeset! Webrev: http://cr.openjdk.java.net/~rprotacio/8141211.02/ I've fixed the multi-line

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Thanks Rachel - looks good. David On 22/12/2015 7:46 AM, Rachel Protacio wrote: Hi, Please take a look at my updated changeset! Webrev: http://cr.openjdk.java.net/~rprotacio/8141211.02/ I've fixed the multi-line statements as requested, i.e. put newlines in them to replicate the original

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hello, everyone! I've filed an RFE for this issue. https://bugs.openjdk.java.net/browse/JDK-8145934 It'll probably be easier to continue the discussion there. Thanks, Rachel On 12/18/2015 8:29 AM, Staffan Larsen wrote: On 18 dec. 2015, at 14:06, David Holmes

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, Please take a look at my updated changeset! Webrev: http://cr.openjdk.java.net/~rprotacio/8141211.02/ I've fixed the multi-line statements as requested, i.e. put newlines in them to replicate the original format. Since the UL framework atomically writes complete messages, these single

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On 2015-12-18 06:44, David Holmes wrote: On 17/12/2015 6:41 PM, Bengt Rutisson wrote: On 2015-12-16 22:43, Coleen Phillimore wrote: On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio wrote: - each incident of ttyLocker that

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On Dec 18, 2015, at 12:35 AM, Thomas Stüfe wrote: > > Neither advantage nor disadvantage: you keep the TLS-anchored buffer around. > This is nice because next time you log you save an allocation call, but needs > to be managed to not be a memory drain. For instance, in

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On Thu, Dec 17, 2015 at 8:39 PM, Thomas Stüfe wrote: > Hi all, > > we at SAP have years ago added a logging system to our hotspot port which > is in many ways similar to UL but solves the multiline-problem differently. > > (Side note: we are currently discussing whether

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi John, On Fri, Dec 18, 2015 at 5:13 AM, John Rose wrote: > On Dec 17, 2015, at 11:39 AM, Thomas Stüfe > wrote: > > > When we print it, we precede the multiline message with the decorators in > the first line and indent the rest of the lines to

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On 18/12/2015 7:14 PM, Bengt Rutisson wrote: On 2015-12-18 06:44, David Holmes wrote: On 17/12/2015 6:41 PM, Bengt Rutisson wrote: On 2015-12-16 22:43, Coleen Phillimore wrote: On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

> On 18 dec. 2015, at 14:06, David Holmes wrote: > > On 18/12/2015 7:14 PM, Bengt Rutisson wrote: >> >> >> On 2015-12-18 06:44, David Holmes wrote: >>> On 17/12/2015 6:41 PM, Bengt Rutisson wrote: On 2015-12-16 22:43, Coleen Phillimore wrote: > On 12/16/15

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On 2015-12-16 22:43, Coleen Phillimore wrote: On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio wrote: - each incident of ttyLocker that involved separate logging lines for the same message have been consolidated to one line -

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, On 2015-12-17 09:41, Bengt Rutisson wrote: On 2015-12-16 22:43, Coleen Phillimore wrote: On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio wrote: - each incident of ttyLocker that involved separate logging lines for the

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi all, we at SAP have years ago added a logging system to our hotspot port which is in many ways similar to UL but solves the multiline-problem differently. (Side note: we are currently discussing whether to abandon our logging system in favour of UL, just because merging down- and upstream

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On 17/12/2015 6:41 PM, Bengt Rutisson wrote: On 2015-12-16 22:43, Coleen Phillimore wrote: On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio wrote: - each incident of ttyLocker that involved separate logging lines for the same

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On Dec 17, 2015, at 11:39 AM, Thomas Stüfe wrote: > > When we print it, we precede the multiline message with the decorators in the > first line and indent the rest of the lines to the same position: > > [time][pid][tid] hallo1 > hallo2 >

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi Rachel, On 16/12/2015 6:26 AM, Rachel Protacio wrote: Hi, Thanks for the comments, David. I had messed up my uploading before and had not actually updated the open html. So for real this time, the most recent webrev is at http://cr.openjdk.java.net/~rprotacio/8141211.01/ Of note: - each

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On Dec 15, 2015, at 12:26 PM, Rachel Protacio wrote: > > - each incident of ttyLocker that involved separate logging lines for the > same message have been consolidated to one line > - each incident of ttyLocker that involved separate print statements to one >

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

On 12/16/15 4:01 PM, John Rose wrote: On Dec 15, 2015, at 12:26 PM, Rachel Protacio wrote: - each incident of ttyLocker that involved separate logging lines for the same message have been consolidated to one line - each incident of ttyLocker that involved

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, On 12/16/2015 3:52 PM, David Holmes wrote: Hi Rachel, On 16/12/2015 6:26 AM, Rachel Protacio wrote: Hi, Thanks for the comments, David. I had messed up my uploading before and had not actually updated the open html. So for real this time, the most recent webrev is at

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi Rachel, On 17/12/2015 7:33 AM, Rachel Protacio wrote: Hi, On 12/16/2015 3:52 PM, David Holmes wrote: Hi Rachel, On 16/12/2015 6:26 AM, Rachel Protacio wrote: Hi, Thanks for the comments, David. I had messed up my uploading before and had not actually updated the open html. So for real

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, Thanks for the comments, David. I had messed up my uploading before and had not actually updated the open html. So for real this time, the most recent webrev is at http://cr.openjdk.java.net/~rprotacio/8141211.01/ Of note: - each incident of ttyLocker that involved separate logging lines

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi Rachel, On 12/12/2015 7:38 AM, Rachel Protacio wrote: Hello! An update and updated webrev. I've rewritten the two portions of code that had used ttyLockers to print in one function-call, since there is no locker equivalent in UL, plus the fact that it will be easier for users to look for

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, Thanks for the review. Replies inline. Updated webrev: http://cr.openjdk.java.net/~rprotacio/8141211.01/ On 12/8/2015 10:53 PM, David Holmes wrote: Hi Rachel, On 9/12/2015 1:42 AM, Rachel Protacio wrote: Hello, Please review my conversion of -XX:+TraceExceptions to

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, (Sorry if this sent twice. Thunderbird is acting up.) Thanks for the review. Replies inline. Updated webrev: http://cr.openjdk.java.net/~rprotacio/8141211.01/ On 12/8/2015 10:53 PM, David Holmes wrote: Hi Rachel, On 9/12/2015 1:42 AM, Rachel Protacio wrote: Hello, Please review my

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi, Are the aliases listed in the -XX usage help? +TraceExceptions is so much easier to understand and use than the new flag. Thanks, Roger On 12/08/2015 10:42 AM, Rachel Protacio wrote: Hello, Please review my conversion of -XX:+TraceExceptions to -Xlog:exceptions=info. The existing

Re: RFR: 8141211: Convert TraceExceptions to Unified Logging

Hi Rachel, On 9/12/2015 1:42 AM, Rachel Protacio wrote: Hello, Please review my conversion of -XX:+TraceExceptions to -Xlog:exceptions=info. The existing (product) flag is aliased to the logging flag at the info level. Q: how does use of ttyLocker map into UL? I see an awful lot of