us Larsson
Sent: den 15 december 2015 11:25
To: serviceability-dev@openjdk.java.net
Cc: hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: 8145083: Use semaphore instead of mutex for
synchronization of Unified Logging configuration
Hi,
New webrev:
http://cr.openjdk.java.net/~mlarsson/8145083/web
Thanks for reviewing, Kim!
On 2015-12-16 18:07, Kim Barrett wrote:
On Dec 15, 2015, at 10:12 AM, Marcus Larsson wrote:
I think it's worth another round. :)
New webrev:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.04/
Incremental:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.03-
@openjdk.java.net
Cc: hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: 8145083: Use semaphore instead of mutex for
synchronization of Unified Logging configuration
Hi,
New webrev:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.03/
Incremental:
http://cr.openjdk.java.net/~mlarsson/
On Dec 15, 2015, at 10:12 AM, Marcus Larsson wrote:
>
> I think it's worth another round. :)
>
> New webrev:
> http://cr.openjdk.java.net/~mlarsson/8145083/webrev.04/
>
> Incremental:
> http://cr.openjdk.java.net/~mlarsson/8145083/webrev.03-04/
Looks good.
I like the reorganization around the
-...@openjdk.java.net; serviceability-dev@openjdk.java.net
Subject: Re: RFR: 8145083: Use semaphore instead of mutex for synchronization
of Unified Logging configuration
Hey Markus,
On 2015-12-15 11:58, Markus Gronlund wrote:
Hi Marcus,
Looks good!
One minor thing that you don't need to fix i
>
> Good work!
>
> /Markus
>
>
>
>
> -Original Message-
> From: Marcus Larsson
> Sent: den 15 december 2015 11:25
> To: serviceability-dev@openjdk.java.net
> Cc: hotspot-runtime-...@openjdk.java.net
> Subject: Re: RFR: 8145083: Use semaphore i
e: RFR: 8145083: Use semaphore instead of mutex for synchronization
of Unified Logging configuration
Hi,
New webrev:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.03/
Incremental:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.02-03/
ConfigurationLocker renamed to ConfigurationLock to
penjdk.java.net
Subject: Re: RFR: 8145083: Use semaphore instead of mutex for synchronization
of Unified Logging configuration
Hi,
New webrev:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.03/
Incremental:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.02-03/
ConfigurationLo
Hi,
New webrev:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.03/
Incremental:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.02-03/
ConfigurationLocker renamed to ConfigurationLock to avoid confusion with
the MutexLocker family of classes.
Semaphore and locking thread id moved into
hanks for looking at this!
Marcus
Thanks
Markus
-Original Message-
From: Marcus Larsson
Sent: den 14 december 2015 16:31
To: serviceability-dev@openjdk.java.net
Cc: hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: 8145083: Use semaphore instead of mutex for synchronization
of Unif
Hi Kim,
On 2015-12-15 02:17, Kim Barrett wrote:
On Dec 14, 2015, at 9:53 AM, Marcus Larsson wrote:
Hi,
New webrev:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.01/
Incremental:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.00-01/
One minor nit:
On Dec 14, 2015, at 9:53 AM, Marcus Larsson wrote:
>
> Hi,
>
> New webrev:
> http://cr.openjdk.java.net/~mlarsson/8145083/webrev.01/
>
> Incremental:
> http://cr.openjdk.java.net/~mlarsson/8145083/webrev.00-01/
One minor nit:
---
java.net
Cc: hotspot-runtime-...@openjdk.java.net
Subject: Re: RFR: 8145083: Use semaphore instead of mutex for synchronization
of Unified Logging configuration
Hi again,
Made some changes to the patch after feedback from Markus Grönlund. The
ConfigurationLocker and the semaphore have b
Hi again,
Made some changes to the patch after feedback from Markus Grönlund. The
ConfigurationLocker and the semaphore have been moved out of the
LogConfiguration.hpp and into the .cpp instead. The lock is only used
internally by the LogConfiguration so this makes sense. It simplifies
the Lo
Hi David,
On 2015-12-14 13:53, David Holmes wrote:
Hi Marcus,
Looks good!
Thanks!
On 14/12/2015 8:13 PM, Marcus Larsson wrote:
Hi,
Please review the following patch to use a semaphore instead of a mutex
for the synchronization of log configuration. Using a mutex requires
some parts of t
Hi,
New webrev:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.01/
Incremental:
http://cr.openjdk.java.net/~mlarsson/8145083/webrev.00-01/
Changes:
* Introduced the ConfigurationLocker class for automatic wait/signal in
constructor/destructor just like a MutexLocker.
* Added an assert to
Hi Marcus,
Looks good!
On 14/12/2015 8:13 PM, Marcus Larsson wrote:
Hi,
Please review the following patch to use a semaphore instead of a mutex
for the synchronization of log configuration. Using a mutex requires
some parts of the VM to be initialized, whereas the semaphores can be
used right
Hi,
Please review the following patch to use a semaphore instead of a mutex
for the synchronization of log configuration. Using a mutex requires
some parts of the VM to be initialized, whereas the semaphores can be
used right from the start. This simplifies the code and allows very
early log
18 matches
Mail list logo
