Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

2016-04-26 Thread Robbin Ehn
Hi Serguei, Thanks! /Robbin On 04/26/2016 10:48 AM, serguei.spit...@oracle.com wrote: Hi Robin, Looks good. Thanks, Serguei On 4/20/16 04:47, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to print_on.

Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

2016-04-26 Thread serguei.spit...@oracle.com
Hi Robin, Looks good. Thanks, Serguei On 4/20/16 04:47, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to print_on. Since JvmtiBreakpoint extends GrowableElement print_on already exists as a virtual const

Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

2016-04-26 Thread Robbin Ehn
Thanks Staffan! /Robbin On 04/26/2016 10:18 AM, Staffan Larsen wrote: Looks good! Thanks, /Staffan On 20 apr. 2016, at 13:47, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to

Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

2016-04-20 Thread Robbin Ehn
Thanks Marcus! /Robbin On 04/20/2016 01:54 PM, Marcus Larsson wrote: Hi, On 04/20/2016 01:47 PM, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to print_on. Since JvmtiBreakpoint extends GrowableElement

Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

2016-04-20 Thread Marcus Larsson
Hi, On 04/20/2016 01:47 PM, Robbin Ehn wrote: Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to print_on. Since JvmtiBreakpoint extends GrowableElement print_on already exists as a virtual const method, hence the const changes.

RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()

2016-04-20 Thread Robbin Ehn
Hi all, please review! print() method was changed in 8154041 to have outputStream argument, this renames print to print_on. Since JvmtiBreakpoint extends GrowableElement print_on already exists as a virtual const method, hence the const changes. Bug: