Re: RFR: 8189440: Event tracing macros for allocation and weak oops processing

2017-10-18 Thread David Holmes
On 19/10/2017 5:33 AM, Erik Gahlin wrote: Hi David, Hi Erik, On 18/10/2017 12:34 PM, Erik Gahlin wrote: Hi, Could I have a review of a change that adds two macros to be used with event-based JVM tracing. Bug: https://bugs.openjdk.java.net/browse/JDK-8189440 Webrev: http://cr.openjdk.java

Re: RFR: 8189440: Event tracing macros for allocation and weak oops processing

2017-10-18 Thread Erik Gahlin
Hi David, Hi Erik, On 18/10/2017 12:34 PM, Erik Gahlin wrote: Hi, Could I have a review of a change that adds two macros to be used with event-based JVM tracing. Bug: https://bugs.openjdk.java.net/browse/JDK-8189440 Webrev: http://cr.openjdk.java.net/~egahlin/8189440_0 Reviewed - though

Re: RFR: 8189440: Event tracing macros for allocation and weak oops processing

2017-10-18 Thread Erik Helin
I'm adding hotspot-gc-dev since GC code is touched and not all GC developers are on serviceability-dev (probably just me). Thanks, Erik On 10/18/2017 04:34 AM, Erik Gahlin wrote: Hi, Could I have a review of a change that adds two macros to be used with event-based JVM tracing. Bug: https:

Re: RFR: 8189440: Event tracing macros for allocation and weak oops processing

2017-10-17 Thread David Holmes
Hi Erik, On 18/10/2017 12:34 PM, Erik Gahlin wrote: Hi, Could I have a review of a change that adds two macros to be used with event-based JVM tracing. Bug: https://bugs.openjdk.java.net/browse/JDK-8189440 Webrev: http://cr.openjdk.java.net/~egahlin/8189440_0 Reviewed - though all somewha

RFR: 8189440: Event tracing macros for allocation and weak oops processing

2017-10-17 Thread Erik Gahlin
Hi, Could I have a review of a change that adds two macros to be used with event-based JVM tracing. Bug: https://bugs.openjdk.java.net/browse/JDK-8189440 Webrev: http://cr.openjdk.java.net/~egahlin/8189440_0 Thanks Erik