Re: RFR: 8202417: [TESTBUG] Broken hard-coded dependency in serviceability/sa/ClhsdbJhisto.java

2018-04-30 Thread Jini George
Hi Claes, This looks fine to me. Thanks, Jini. (Not a Reviewer) On 4/30/2018 3:00 PM, Claes Redestad wrote: Hi, ClhsdbJhisto has a hard-coded dependency on an ImmutableCollections$SetN$1 appearing in the jhisto output, which is fragile and sometimes break after JDK-8201650. I suggest removi

Re: RFR: 8202417: [TESTBUG] Broken hard-coded dependency in serviceability/sa/ClhsdbJhisto.java

2018-04-30 Thread Claes Redestad
On 2018-04-30 11:33, Alan Bateman wrote: This looks okay, at least as a short term fix. I agree it's way too fragile to depend on such classes and needs to stick to classes that are closer to the area that it tests. Thanks, Alan! /Claes

Re: RFR: 8202417: [TESTBUG] Broken hard-coded dependency in serviceability/sa/ClhsdbJhisto.java

2018-04-30 Thread Alan Bateman
On 30/04/2018 10:30, Claes Redestad wrote: Hi, ClhsdbJhisto has a hard-coded dependency on an ImmutableCollections$SetN$1 appearing in the jhisto output, which is fragile and sometimes break after JDK-8201650. I suggest removing it from the test: diff -r 96d4658eb7f2 test/hotspot/jtreg/s

RFR: 8202417: [TESTBUG] Broken hard-coded dependency in serviceability/sa/ClhsdbJhisto.java

2018-04-30 Thread Claes Redestad
Hi, ClhsdbJhisto has a hard-coded dependency on an ImmutableCollections$SetN$1 appearing in the jhisto output, which is fragile and sometimes break after JDK-8201650. I suggest removing it from the test: diff -r 96d4658eb7f2 test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java --- a/test/h