Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation [v2]

2021-12-15 Thread Coleen Phillimore
On Tue, 14 Dec 2021 17:42:00 GMT, Coleen Phillimore wrote: >> This change makes VM_Version_Ext part of VM_Version (the platform dependent >> part) and moves some duplicated code. x86 had the most code in >> VM_Version_Ext, so the most code moved there. There might be some unneeded >> function

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation [v2]

2021-12-14 Thread David Holmes
On Tue, 14 Dec 2021 17:42:00 GMT, Coleen Phillimore wrote: >> This change makes VM_Version_Ext part of VM_Version (the platform dependent >> part) and moves some duplicated code. x86 had the most code in >> VM_Version_Ext, so the most code moved there. There might be some unneeded >> function

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation [v2]

2021-12-14 Thread Coleen Phillimore
On Tue, 14 Dec 2021 17:42:00 GMT, Coleen Phillimore wrote: >> This change makes VM_Version_Ext part of VM_Version (the platform dependent >> part) and moves some duplicated code. x86 had the most code in >> VM_Version_Ext, so the most code moved there. There might be some unneeded >> function

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation [v2]

2021-12-14 Thread Harold Seigel
On Tue, 14 Dec 2021 17:42:00 GMT, Coleen Phillimore wrote: >> This change makes VM_Version_Ext part of VM_Version (the platform dependent >> part) and moves some duplicated code. x86 had the most code in >> VM_Version_Ext, so the most code moved there. There might be some unneeded >> function

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation [v2]

2021-12-14 Thread Coleen Phillimore
On Tue, 14 Dec 2021 16:24:10 GMT, Coleen Phillimore wrote: >> src/hotspot/os/linux/os_perf_linux.cpp line 929: >> >>> 927: bool CPUInformationInterface::initialize() { >>> 928: _cpu_info = new CPUInformation(); >>> 929: VM_Version::initialize_cpu_information(); >> >> I can't figure out when

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation [v2]

2021-12-14 Thread Coleen Phillimore
> This change makes VM_Version_Ext part of VM_Version (the platform dependent > part) and moves some duplicated code. x86 had the most code in > VM_Version_Ext, so the most code moved there. There might be some unneeded > functions but I didn't want to remove them with this change. > > Tier1 (

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation

2021-12-14 Thread Coleen Phillimore
On Mon, 13 Dec 2021 23:14:43 GMT, Coleen Phillimore wrote: > This change makes VM_Version_Ext part of VM_Version (the platform dependent > part) and moves some duplicated code. x86 had the most code in > VM_Version_Ext, so the most code moved there. There might be some unneeded > functions bu

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation

2021-12-14 Thread Coleen Phillimore
On Tue, 14 Dec 2021 02:32:54 GMT, David Holmes wrote: >> This change makes VM_Version_Ext part of VM_Version (the platform dependent >> part) and moves some duplicated code. x86 had the most code in >> VM_Version_Ext, so the most code moved there. There might be some unneeded >> functions but

Re: RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation

2021-12-13 Thread David Holmes
On Mon, 13 Dec 2021 23:14:43 GMT, Coleen Phillimore wrote: > This change makes VM_Version_Ext part of VM_Version (the platform dependent > part) and moves some duplicated code. x86 had the most code in > VM_Version_Ext, so the most code moved there. There might be some unneeded > functions bu

RFR: 8202579: Revisit VM_Version and VM_Version_ext for overlap and consolidation

2021-12-13 Thread Coleen Phillimore
This change makes VM_Version_Ext part of VM_Version (the platform dependent part) and moves some duplicated code. x86 had the most code in VM_Version_Ext, so the most code moved there. There might be some unneeded functions but I didn't want to remove them with this change. Tier1 (tier2-4 test