RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Could you please review following patch which rewrite vmTestbase/heapdump tests as a jtreg java tests. These heapdump tests were developed as a shell tests which verify heapdump functionality in JDK 5. They work fine but needs some refactoring. webrev: http://cr.openjdk.java.net/~lmesnik/

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Leonid, I have mostly looked at only the following file: http://cr.openjdk.java.net/~lmesnik/8203491/webrev.00/test/hotspot/jtreg/serviceability/sa/TestJmapCore.java.html * Would you be adding JMapMetaspaceCore testing to this? Other than this, I think the jhsdb heapdump testing from vmTest

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Thank you for review and feedback. See my comments inline. I am going to get more feedback and then send new version with fixes for your comments. > On May 23, 2018, at 8:48 AM, Jini George wrote: > > Hi Leonid, > > I have mostly looked at only the following file: > > http://cr.openjdk.

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Leonid, My comments inline. On 5/24/2018 12:09 AM, Leonid Mesnik wrote: I am not sure that JMapMetaspaceCore provides any additional coverage. The test just fill 64M of metaspace and then send signal to dump core. So I don't see how this test could improve coverage. I think that idea of or

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Found new webrev here: http://cr.openjdk.java.net/~lmesnik/8203491/webrev.01/ and inc diff http://cr.openjdk.java.net/~lmesnik/8203491/webrev.01-00/ I don't know if existing 6

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Leonid, I haven't reviewed your change fully, although I noticed that you merged several tests into one -- TestHeapDumpOnOutOfMemoryError, I don't think it's a good idea as we lose atomicity of test results/executions. could you please split TestHeapDumpOnOutOfMemoryError into independent te

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Hi Thanks for feedback. It is a good idea. Split TestHeapDumpOnOutOfMemoryError into 3 tests. The only test TestHeapDumpOnOutOfMemoryErrorInMetaspace.java requires timeout=240 and excluded from tier1 now. Also I fixed parameters for TestHeapDumpPath test and removed unneeded '@modules java.bas

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

The SA tests look good to me. One minor comment. public static String HEAP_OOME = "heap"; public static String METASPACE_OOME = "metaspace"; These could be declared as public static final String. Thanks, Jini. On 5/25/2018 4:37 AM, Leonid Mesnik wrote: Hi Thanks for feedback. It is

Re: RFR: 8203491: [TESTBUG] Port heapdump tests into java

Jini Thank you for review. I added final. Still waiting for review from 'R'eviewer and from runtime. Leonid > On May 24, 2018, at 11:31 PM, Jini George wrote: > > The SA tests look good to me. One minor comment. > >public static String HEAP_OOME = "heap"; >public static String METASP