RFR: 8214499: SA should follow 8150689

Hi David, Poonam, I filed this issue to JBS and uploaded webrev: JBS: https://bugs.openjdk.java.net/browse/JDK-8214499 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8214499/webrev.00/ This change works fine on test/hotspot/jtreg/serviceability/sa jtreg test and submit repo (mach5-one-ysue

Re: RFR: 8214499: SA should follow 8150689

Hi Yasumasa, On 30/11/2018 1:39 pm, Yasumasa Suenaga wrote: Hi David, Poonam, I filed this issue to JBS and uploaded webrev: JBS: https://bugs.openjdk.java.net/browse/JDK-8214499 webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8214499/webrev.00/ This change works fine on test/hotspot/j

Re: RFR: 8214499: SA should follow 8150689

Thanks David! I will remove them. Yasumasa 2018年11月30日(金) 13:09 David Holmes : > > Hi Yasumasa, > > On 30/11/2018 1:39 pm, Yasumasa Suenaga wrote: > > Hi David, Poonam, > > > > I filed this issue to JBS and uploaded webrev: > > > >JBS: https://bugs.openjdk.java.net/browse/JDK-8214499 > >

Re: RFR: 8214499: SA should follow 8150689

The change looks good to me, Yasumasa. (One minor nit: line 110: 2 spaces instead of 4 to align with the rest of the file). Would the second part of this comment, 126 // Print out all monitors that we have locked, or are trying to lock, 127 // including re-locking after being notifi

Re: RFR: 8214499: SA should follow 8150689

Hi Jini, On 2018/11/30 15:15, Jini George wrote: The change looks good to me, Yasumasa. (One minor nit: line 110: 2 spaces instead of 4 to align with the rest of the file). Thanks! I will fix it. Would the second part of this comment, 126 // Print out all monitors that we have locked

Re: RFR: 8214499: SA should follow 8150689

Yes, Yasumasa. You can push the fix. Thanks! - Jini. On 11/30/2018 12:36 PM, Yasumasa Suenaga wrote: Hi Jini, On 2018/11/30 15:15, Jini George wrote: The change looks good to me, Yasumasa. (One minor nit: line 110: 2 spaces instead of 4 to align with the rest of the file). Thanks! I will