Re: RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

2019-06-14 Thread serguei . spitsyn
On 6/14/19 5:44 PM, Jean Christophe Beyler wrote: Hi Daniil, Looks good to me to :-) FWIW, it seems like: opto/library_call.cpp:    if (!C->too_many_traps(trap_method, trap_bci, Deoptimization::Reason_intrinsic) &           !C->too_many_traps(trap_method, trap_bci,

Re: RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

2019-06-14 Thread Alex Menkov
+1 --alex On 06/14/2019 17:01, serguei.spit...@oracle.com wrote: Hi Daniil, Great discovery! The fix looks good to me. Thanks, Serguei On 6/14/19 4:56 PM, Daniil Titov wrote: Please review the change that fixes an intermittent issue. The problem here is that a bitwise-AND (&) operator

Re: RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

2019-06-14 Thread serguei . spitsyn
Hi Daniil, Great discovery! The fix looks good to me. Thanks, Serguei On 6/14/19 4:56 PM, Daniil Titov wrote: Please review the change that fixes an intermittent issue. The problem here is that a bitwise-AND (&) operator was used in the condition instead of a logical AND operator (&&). As

RFR: 8217348: assert(thread->is_Java_thread()) failed: just checking

2019-06-14 Thread Daniil Titov
Please review the change that fixes an intermittent issue. The problem here is that a bitwise-AND (&) operator was used in the condition instead of a logical AND operator (&&). As a result pending_thread->is_thread_fully_suspended() is always evaluated regardless of the value of at_safepoint