Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

2019-02-14 Thread Stefan Karlsson
Hi Jini, On 2019-02-14 18:11, Jini George wrote: Hi Stefan, Other than the getAddressField to getField change and the comments by Erik, I just have a couple of nits to add. 1. This line in VMOopHandle.java can be removed: 31 import sun.jvm.hotspot.runtime.VMObjectFactory; Done. 2. The

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

2019-02-14 Thread Jini George
Hi Stefan, Other than the getAddressField to getField change and the comments by Erik, I just have a couple of nits to add. 1. This line in VMOopHandle.java can be removed: 31 import sun.jvm.hotspot.runtime.VMObjectFactory; 2. The copyright year for some of the files need updation. This

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

2019-02-14 Thread Stefan Karlsson
On 2019-02-14 10:01, Erik Ă–sterlund wrote: Hi Stefan, Looks good. One thing though... At VMOopHandle.java line 38: * Remove weird double indentation * Remove weird double semicolon * Use Field instead of AddressField I'll fix. I don't think I need another webrev. Thanks for reviewing.

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

2019-02-14 Thread Erik Ă–sterlund
Hi Stefan, Looks good. One thing though... At VMOopHandle.java line 38: * Remove weird double indentation * Remove weird double semicolon * Use Field instead of AddressField I don't think I need another webrev. Thanks, /Erik On 2019-02-11 09:39, Stefan Karlsson wrote: Hi all, Please

Re: RFR: 8218734: SA: Incorrect and raw loads of OopHandles

2019-02-13 Thread Stefan Karlsson
On 2019-02-13 17:12, coleen.phillim...@oracle.com wrote: On 2/13/19 10:40 AM, Stefan Karlsson wrote: On 2019-02-13 14:40, coleen.phillim...@oracle.com wrote: On 2/11/19 3:39 AM, Stefan Karlsson wrote: Hi all, Please review this patch to fix the resolving of oops inside the (VM)

RFR: 8218734: SA: Incorrect and raw loads of OopHandles

2019-02-11 Thread Stefan Karlsson
Hi all, Please review this patch to fix the resolving of oops inside the (VM) OopHandles. https://cr.openjdk.java.net/~stefank/8218734/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8218734 Before this patch the OopHandle::_obj was assumed to be located at offset 0, and the SA resolved