Re: RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

2019-02-14 Thread Stefan Karlsson
On 2019-02-14 17:04, Jini George wrote: Hi Stefan, Looks good to me. Nit: Could you please modify the copyright year? And don't we have to add the copyright message to the new file ZExternalBitMap.java ? Thanks. I've gone through all my SA patches and updated the copyright year. StefanK

Re: RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

2019-02-14 Thread Jini George
Hi Stefan, Looks good to me. Nit: Could you please modify the copyright year? And don't we have to add the copyright message to the new file ZExternalBitMap.java ? Thanks! Jini. On 2/11/2019 7:25 PM, Stefan Karlsson wrote: Hi all, Please review this patch to implement a discontiuous

Re: RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

2019-02-14 Thread Stefan Karlsson
On 2019-02-14 10:22, Erik Ă–sterlund wrote: Hi Stefan, At ZExternalBitMap line 22: * Maybe add a bounds check for offsets < 0 as well. At ZExternalBitMap line 45: * Remove weird whitespace in argument list. * Consider inverting the condition to early exit. Don't mind if you choose to do that

Re: RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

2019-02-14 Thread Erik Ă–sterlund
Hi Stefan, At ZExternalBitMap line 22: * Maybe add a bounds check for offsets < 0 as well. At ZExternalBitMap line 45: * Remove weird whitespace in argument list. * Consider inverting the condition to early exit. Don't mind if you choose to do that or not. Otherwise looks good. Don't need

RFR: 8218746: SA: Implement discontiguous bitmap for ZGC

2019-02-11 Thread Stefan Karlsson
Hi all, Please review this patch to implement a discontiuous bitmap for ZGC in the SA. http://cr.openjdk.java.net/~stefank/8218746/webrev.01/ https://bugs.openjdk.java.net/browse/JDK-8218746 ZGC uses a 16TB virtual memory address range, so the normal scheme to map a bitmap over the entire