Re: RFR: 8220682: Heap dumping and inspection fails with JDK-8214712

2019-03-25 Thread Claes Redestad
On 2019-03-25 23:10, serguei.spit...@oracle.com wrote: Hi Claes, It looks good. I've targeted the bug to 13. Thanks, Serguei! /Claes

Re: RFR: 8220682: Heap dumping and inspection fails with JDK-8214712

2019-03-25 Thread serguei.spit...@oracle.com
Hi Claes, It looks good. I've targeted the bug to 13. Thanks, Serguei On 3/25/19 04:23, Claes Redestad wrote: [Adding hotspot-runtime-dev] On 2019-03-15 17:26, Claes Redestad wrote: Hi, I ran into a few additional test issues, one exposing a crash in jmap -histo:live in a test that seems t

Re: RFR: 8220682: Heap dumping and inspection fails with JDK-8214712

2019-03-25 Thread Claes Redestad
On 2019-03-25 17:51, Jiangli Zhou wrote: Hi Claes, The updated change also matches with the state of shared klasses, so it seems good to me. Thanks! Sorry for the delay. No worries, I was on vacation last week. :-) It's probably a good idea to add an assert to make sure k->is_shared

Re: RFR: 8220682: Heap dumping and inspection fails with JDK-8214712

2019-03-25 Thread Claes Redestad
[Adding hotspot-runtime-dev] On 2019-03-15 17:26, Claes Redestad wrote: Hi, I ran into a few additional test issues, one exposing a crash in jmap -histo:live in a test that seems to have been problem listed when I ran tests earlier. Also filtering out archived-but-not-yet-loaded classes in Kla

Re: RFR: 8220682: Heap dumping and inspection fails with JDK-8214712

2019-03-25 Thread Claes Redestad
Ping. Still passes tests and is necessary to unblock work to more aggressively archive invariant heap graphs. /Claes On 2019-03-15 17:26, Claes Redestad wrote: Hi, I ran into a few additional test issues, one exposing a crash in jmap -histo:live in a test that seems to have been problem liste

Re: RFR: 8220682: Heap dumping and inspection fails with JDK-8214712

2019-03-15 Thread Claes Redestad
Hi, I ran into a few additional test issues, one exposing a crash in jmap -histo:live in a test that seems to have been problem listed when I ran tests earlier. Also filtering out archived-but-not-yet-loaded classes in KlassInfoBucket::lookup makes tests exercising jmap etc work as intended in t