Thanks. Created JDK-8237639.
StefanK
On 2020-01-22 10:50, David Holmes wrote:
Hi Stefan,
Thanks David. Would you accept it if I created a follow-up RFR to
investigate if we could change order of the combined flags?
Sure, no problem.
Thanks,
David
On 22/01/2020 6:58 pm, Stefan Karlsson wr
Hi Stefan,
Thanks David. Would you accept it if I created a follow-up RFR to investigate if we could change order of the combined flags?
Sure, no problem.
Thanks,
David
On 22/01/2020 6:58 pm, Stefan Karlsson wrote:
Hi David,
On 2020-01-22 05:28, David Holmes wrote:
Hi Stefan,
Thanks for
Hi David,
On 2020-01-22 05:28, David Holmes wrote:
Hi Stefan,
Thanks for tackling this.
On 22/01/2020 12:58 am, Stefan Karlsson wrote:
Hi all,
Please review this patch to change our usages of LingeredApp and
getVmOptions() to instead use getTestJavaOpts().
https://cr.openjdk.java.net/~ste
Hi Chris,
On 2020-01-21 20:52, Chris Plummer wrote:
Hi Stefan,
Can you explain the un-commenting of the code in JpsHelper.java?
The comment was not removed, but moved over to testVmArgs.
The reason for the change is that I need getVmArgs() to return a
String[] instead of List. So, I initial
Hi Stefan,
Thanks for tackling this.
On 22/01/2020 12:58 am, Stefan Karlsson wrote:
Hi all,
Please review this patch to change our usages of LingeredApp and
getVmOptions() to instead use getTestJavaOpts().
https://cr.openjdk.java.net/~stefank/8237111/webrev.01/
https://bugs.openjdk.java.net
Stefan,
https://cr.openjdk.java.net/~stefank/8237111/webrev.01/test/hotspot/jtreg/serviceability/sa/TestInstanceKlassSizeForInterface.java.udiff.html
Can you also change this line?
- * @run main/othervm -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI
-Xbootclasspath/a:. TestInstanceKlassSize
Hi Stefan,
Can you explain the un-commenting of the code in JpsHelper.java?
Copyrights need updating.
Other than that it looks good.
thanks,
Chris
On 1/21/20 6:58 AM, Stefan Karlsson wrote:
Hi all,
Please review this patch to change our usages of LingeredApp and
getVmOptions() to instead
Hi Stefan, Thank you for cleaning this up! I was expecting VM_OPTIONS
and TEST_VM_OPTS to go away also, but I guess they don't need to since
they are included in getJavaOpts().
The change for LingeredApp.startApp() to take a String[] is good. It was
awkward the way it was in TestInstanceKl
Hi all,
Please review this patch to change our usages of LingeredApp and
getVmOptions() to instead use getTestJavaOpts().
https://cr.openjdk.java.net/~stefank/8237111/webrev.01/
https://bugs.openjdk.java.net/browse/JDK-8237111
This issue was encountered by both Coleen and I, independently.
W
